From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: bug#11672: 23.3; info menu-bar acts on wrong window Date: Wed, 20 Jun 2012 11:05:02 +0200 Message-ID: <4FE1923E.4060907@gmx.at> References: <877gvefbwh.fsf@abara.de> <4FD6E793.4050808@gmx.at> <4FDF1EA4.9000408@abara.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1340183115 21432 80.91.229.3 (20 Jun 2012 09:05:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 20 Jun 2012 09:05:15 +0000 (UTC) Cc: emacs-devel To: Gerhard Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 20 11:05:14 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ShGqd-00068K-1D for ged-emacs-devel@m.gmane.org; Wed, 20 Jun 2012 11:05:11 +0200 Original-Received: from localhost ([::1]:49548 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShGqc-0007Sl-UG for ged-emacs-devel@m.gmane.org; Wed, 20 Jun 2012 05:05:10 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41192) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShGqW-0007Mv-F1 for emacs-devel@gnu.org; Wed, 20 Jun 2012 05:05:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ShGqR-0006cg-Cl for emacs-devel@gnu.org; Wed, 20 Jun 2012 05:05:04 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.23]:46970) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1ShGqR-0006bS-1w for emacs-devel@gnu.org; Wed, 20 Jun 2012 05:04:59 -0400 Original-Received: (qmail invoked by alias); 20 Jun 2012 09:04:56 -0000 Original-Received: from 62-47-39-235.adsl.highway.telekom.at (EHLO [62.47.39.235]) [62.47.39.235] by mail.gmx.net (mp069) with SMTP; 20 Jun 2012 11:04:56 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX185GoNOd6k5LvULKcqUQRGPzy5hsCy8w4EE2PWJA9 IQ/jGVnGslqqiu In-Reply-To: <4FDF1EA4.9000408@abara.de> X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 213.165.64.23 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151049 Archived-At: > Proposition for a bugfix: Please keep emacs-devel cc'd. > Change the call to the interactive-function in Info-up, Info-next, and > Info-prev in the source file "info.el" > > from > (interactive) > to > (interactive "@") > > I think that's all. Or is that too simple? What do you think? > > I tested the bugfix by loading a file with the redefined functions > (load-file "bugfix.el") and it seems to work. For emacs in a text > console with gpm mouse support navigating by mouse in an inactive window > seems to be not possible. > > Maybe the save-window-excursion in the function source, that seems to be > provided for the case that another window is selected, is not really > necessary, because selecting the window with the menu-bar To avoid confusion, this is "the window with the header line". > is most > probably intended by the user. When he used the mouse. In any case the (or (eq major-mode 'Info-mode) (switch-to-buffer "*info*")) in `Info-up' and friends means that we do have to make current the buffer of the window where the mouse click happened. So I think using (interactive "@") is TRT. Any objections? martin