bug#11577: 24.1.50; show-paren-mode broken in trunk

bug#11577: 24.1.50; show-paren-mode broken in trunk

[martin rudalics]

Some change in the last four days broke `show-paren-mode' here:

With emacs -Q evaluating

(custom-set-variables
  '(show-paren-delay 0.125)
  '(show-paren-mode t)
  '(show-paren-style (quote parenthesis)))

and moving the cursor after a right parenthesis doesn't highlight the
corresponding left parenthesis any more although the overlay is still
present as indicated by:

              position: 6003 of 462623 (1%), column: 8
             character: ( (displayed as () (codepoint 40, #o50, #x28)
     preferred charset: ascii (ASCII (ISO646 IRV))
code point in charset: 0x28
                syntax: ()	which means: open, matches )
              category: .:Base, a:ASCII, l:Latin, r:Roman
           buffer code: #x28
             file code: #x28 (encoded by coding system utf-8-unix)
               display: by this font (glyph code)
     uniscribe:-outline-Courier New-normal-normal-normal-mono-13-*-*-*-c-*-iso8859-1 (#x0B)

Character code properties: customize what to show
   name: LEFT PARENTHESIS
   old-name: OPENING PARENTHESIS
   general-category: Ps (Punctuation, Open)
   decomposition: (40) ('(')

There is an overlay here:
  From 6003 to 6004
   face                 show-paren-match
   priority             1000


There are text properties here:
   fontified            t


In GNU Emacs 24.1.50.1 (i386-mingw-nt5.1.2600)
  of 2012-05-29 on MACHNO
Bzr revision: 108414 eggert@cs.ucla.edu-20120529061649-6yb9ceosy38bayh0
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
  `configure --with-gcc (4.6) --no-opt'

Important settings:
   value of $LC_ALL: nil
   value of $LC_COLLATE: nil
   value of $LC_CTYPE: nil
   value of $LC_MESSAGES: nil
   value of $LC_MONETARY: nil
   value of $LC_NUMERIC: nil
   value of $LC_TIME: nil
   value of $LANG: ENU
   value of $XMODIFIERS: nil
   locale-coding-system: cp1252
   default enable-multibyte-characters: t

Major mode: Fundamental

Minor modes in effect:
   show-paren-mode: t
   tooltip-mode: t
   mouse-wheel-mode: t
   tool-bar-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   blink-cursor-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t
   line-number-mode: t
   transient-mark-mode: (only . t)

Recent input:
( a b c ) <return> ( <backspace> <insert> C-y <up>
<up> <up> <up> <M-delete> <return> <return> <S-down>
<delete> <insert> C-y <down> <down> <down> <left> <C-left>
<C-left> <C-left> <C-left> <C-left> <C-left> <down-mouse-1>
<mouse-1> ) C-x C-e <left> <right> <left> <left> <right>
<right> <left> <left> <right> <right> <up> <up> <up>
<up> <right> <S-down> <S-down> <S-down> <S-down> <S-down>
<insert> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <tool-bar> <copy> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <menu-bar> <help-menu> <about-emacs>
<help-echo> <help-echo> <help-echo> <down> <S-down>
<S-down> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <menu-bar> <help-menu> <send-emacs-bug
-report>

Recent messages:
Mark set [2 times]
Overwrite mode disabled
Mark set
Loading paren...done
nil
Mark set
byte-code: End of buffer
Overwrite mode enabled
For information about GNU Emacs and the GNU system, type C-h C-a.
Mark set

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mail-utils paren cus-start time-date tooltip
ediff-hook vc-hooks lisp-float-type mwheel dos-w32 disp-table ls-lisp
w32-win w32-vars tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment lisp-mode register page menu-bar rfn-eshadow
timer select scroll-bar mouse jit-lock font-lock syntax facemenu
font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan
thai tai-viet lao korean japanese hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese case-table epa-hook
jka-cmpr-hook help simple abbrev minibuffer button faces cus-face files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
multi-tty emacs)

bug#11577: 24.1.50; show-paren-mode broken in trunk

[Ari Roponen]

martin rudalics <rudalics@gmx.at> writes:

> Some change in the last four days broke `show-paren-mode' here:
>

I was just about to report the same problem :-)

Using GIT + bisect, I found that the bug comes from:

  commit 96f1e61015615eef4fce55e7a4b1019e8e215efc
  Author: Paul Eggert <eggert@cs.ucla.edu>
  Date:   Fri May 25 13:30:19 2012 -0700

      * src/buffer.c (Fmove_overflay): Clip instead of trying to fix bug 9642.

The following patch seems to fix the problem:

diff --git a/src/buffer.c b/src/buffer.c
index 5d431f2..74d2efb 100644
--- a/src/buffer.c
+++ b/src/buffer.c
@@ -3758,8 +3758,8 @@ buffer.  */)
       eassert (XOVERLAY (overlay)->next == NULL);
     }
 
-  Fset_marker (OVERLAY_START (overlay), beg, buffer);
-  Fset_marker (OVERLAY_END   (overlay), end, buffer);
+  Fset_marker (OVERLAY_START (overlay), make_number (n_beg), buffer);
+  Fset_marker (OVERLAY_END   (overlay), make_number (n_end), buffer);
 
   /* Put the overlay on the wrong list.  */
   end = OVERLAY_END (overlay);


-- 
Ari Roponen

bug#11577: Acknowledgement (24.1.50; show-paren-mode broken in trunk)

[martin rudalics]

Fixed by some change in the last days.

martin