bug#11567: 24.0.97; WTF? ROFL! (hilarious bug)

[martin rudalics <rudalics@gmx.at>]

[-- Attachment #1: Type: text/plain, Size: 266 bytes --]

 >> Why can't we use `window--delete' instead of `iconify-frame' here?
 >
 > Probably no reason.

Then maybe we should use `quit-window' in the first place.  Attached
find a patch for those who would give it a try (I hardly ever see the
completions buffer).

martin

[-- Attachment #2: simple.diff --]
[-- Type: text/plain, Size: 929 bytes --]

*** lisp/simple.el	2012-05-04 23:16:47 +0000
--- lisp/simple.el	2012-05-28 17:54:25 +0000
***************
*** 6212,6227 ****
  
        (unless (buffer-live-p buffer)
          (error "Destination buffer is dead"))
!       (select-window (posn-window (event-start event)))
!       (if (and (one-window-p t 'selected-frame)
! 	       (window-dedicated-p (selected-window)))
! 	  ;; This is a special buffer's frame
! 	  (iconify-frame (selected-frame))
! 	(or (window-dedicated-p (selected-window))
! 	    (bury-buffer)))
!       (select-window
!        (or (get-buffer-window buffer 0)
!            owindow))
  
        (with-current-buffer buffer
          (choose-completion-string
--- 6212,6218 ----
  
        (unless (buffer-live-p buffer)
          (error "Destination buffer is dead"))
!       (quit-window nil (posn-window (event-start event)))
  
        (with-current-buffer buffer
          (choose-completion-string