From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#11547: 24.0.96; Was a line accidentally commented out in callproc.c? Date: Wed, 23 May 2012 11:03:21 -0400 Message-ID: <4FBCFC39.2090709@cornell.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1337785539 27929 80.91.229.3 (23 May 2012 15:05:39 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 23 May 2012 15:05:39 +0000 (UTC) To: 11547@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 23 17:05:38 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SXD81-0004Bg-Ts for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 May 2012 17:05:34 +0200 Original-Received: from localhost ([::1]:58646 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXD81-0008Ps-E0 for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 May 2012 11:05:33 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXD7p-0008PU-D5 for bug-gnu-emacs@gnu.org; Wed, 23 May 2012 11:05:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXD7j-0006Fj-21 for bug-gnu-emacs@gnu.org; Wed, 23 May 2012 11:05:20 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59481) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXD7i-0006EP-VO for bug-gnu-emacs@gnu.org; Wed, 23 May 2012 11:05:14 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SXD8U-0005j7-Bf for bug-gnu-emacs@gnu.org; Wed, 23 May 2012 11:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 May 2012 15:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 11547 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.133778552921972 (code B ref -1); Wed, 23 May 2012 15:06:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 May 2012 15:05:29 +0000 Original-Received: from localhost ([127.0.0.1]:40794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SXD7w-0005iL-N5 for submit@debbugs.gnu.org; Wed, 23 May 2012 11:05:29 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46657) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SXD7b-0005hg-GM for submit@debbugs.gnu.org; Wed, 23 May 2012 11:05:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXD6c-0005Q7-ES for submit@debbugs.gnu.org; Wed, 23 May 2012 11:04:12 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:39405) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXD6c-0005Pq-9y for submit@debbugs.gnu.org; Wed, 23 May 2012 11:04:06 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXD6X-0007wr-5p for bug-gnu-emacs@gnu.org; Wed, 23 May 2012 11:04:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXD6R-0005JZ-2K for bug-gnu-emacs@gnu.org; Wed, 23 May 2012 11:04:00 -0400 Original-Received: from granite1.mail.cornell.edu ([128.253.83.141]:33893 helo=authusersmtp.mail.cornell.edu) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXD6Q-0005Bb-Ul for bug-gnu-emacs@gnu.org; Wed, 23 May 2012 11:03:55 -0400 Original-Received: from [192.168.1.4] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id q4NF3aLa028621 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Wed, 23 May 2012 11:03:37 -0400 (EDT) User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 X-PMX-CORNELL-SPAM-CHECKED: Pawpaw X-PMX-Version: 5.5.9.395186, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.5.23.145115 X-Original-Sender: kbrown@cornell.edu - Wed May 23 11:03:37 2012 X-PMX-CORNELL-REASON: CU_White_List_Override X-MIME-Autoconverted: from 8bit to quoted-printable by authusersmtp.mail.cornell.edu id q4NF3aLa028621 X-detected-operating-system: by eggs.gnu.org: Solaris 9 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60306 Archived-At: In the course of trying to debug a Cygwin crash, I noticed that line 643=20 of callproc.c is commented out. This was done in bzr revision 103252,=20 and it seems pretty clear from the context of that change that it was=20 done by accident: revno: 103252 committer: Jan D branch nick: trunk timestamp: Sun 2011-02-13 12:28:42 +0100 message: * callproc.c (Fcall_process): * process.c (create_process): Replace Gtk with GConf in SIGPIPE comment. modified: src/ChangeLog src/callproc.c src/process.c diff: =3D=3D=3D modified file 'src/ChangeLog' --- src/ChangeLog 2011-02-13 00:16:28 +0000 +++ src/ChangeLog 2011-02-13 11:28:42 +0000 @@ -1,3 +1,9 @@ +2011-02-13 Jan Dj=E4rv + + * callproc.c (Fcall_process): + * process.c (create_process): Replace Gtk with GConf in SIGPIPE + comment. + 2011-02-12 Martin Rudalics * window.c (select_window): Check inhibit_point_swap argument wh= en =3D=3D=3D modified file 'src/callproc.c' --- src/callproc.c 2011-02-12 18:53:24 +0000 +++ src/callproc.c 2011-02-13 11:28:42 +0000 @@ -559,9 +559,9 @@ setpgrp (pid, pid); #endif /* USG */ - /* GTK causes us to ignore SIGPIPE, make sure it is restored + /* GConf causes us to ignore SIGPIPE, make sure it is restored in the child. */ - signal (SIGPIPE, SIG_DFL); + //signal (SIGPIPE, SIG_DFL); #ifdef HAVE_WORKING_VFORK sigprocmask (SIG_SETMASK, &procmask, 0); #endif =3D=3D=3D modified file 'src/process.c' --- src/process.c 2011-02-12 18:53:24 +0000 +++ src/process.c 2011-02-13 11:28:42 +0000 @@ -2056,7 +2056,7 @@ signal (SIGINT, SIG_DFL); signal (SIGQUIT, SIG_DFL); - /* GTK causes us to ignore SIGPIPE, make sure it is restored + /* GConf causes us to ignore SIGPIPE, make sure it is restored in the child. */ signal (SIGPIPE, SIG_DFL); I don't understand the code well enough to know how critical this is.=20 The comment preceding that line suggests that it could be a problem for=20 a build with GConf support. Ken