From: Ken Brown <kbrown@cornell.edu>
To: 11547@debbugs.gnu.org
Subject: bug#11547: 24.0.96; Was a line accidentally commented out in callproc.c?
Date: Wed, 23 May 2012 11:03:21 -0400 [thread overview]
Message-ID: <4FBCFC39.2090709@cornell.edu> (raw)
In the course of trying to debug a Cygwin crash, I noticed that line 643
of callproc.c is commented out. This was done in bzr revision 103252,
and it seems pretty clear from the context of that change that it was
done by accident:
revno: 103252
committer: Jan D <jan.h.d@swipnet.se>
branch nick: trunk
timestamp: Sun 2011-02-13 12:28:42 +0100
message:
* callproc.c (Fcall_process):
* process.c (create_process): Replace Gtk with GConf in SIGPIPE
comment.
modified:
src/ChangeLog
src/callproc.c
src/process.c
diff:
=== modified file 'src/ChangeLog'
--- src/ChangeLog 2011-02-13 00:16:28 +0000
+++ src/ChangeLog 2011-02-13 11:28:42 +0000
@@ -1,3 +1,9 @@
+2011-02-13 Jan Djärv <jan.h.d@swipnet.se>
+
+ * callproc.c (Fcall_process):
+ * process.c (create_process): Replace Gtk with GConf in SIGPIPE
+ comment.
+
2011-02-12 Martin Rudalics <rudalics@gmx.at>
* window.c (select_window): Check inhibit_point_swap argument when
=== modified file 'src/callproc.c'
--- src/callproc.c 2011-02-12 18:53:24 +0000
+++ src/callproc.c 2011-02-13 11:28:42 +0000
@@ -559,9 +559,9 @@
setpgrp (pid, pid);
#endif /* USG */
- /* GTK causes us to ignore SIGPIPE, make sure it is restored
+ /* GConf causes us to ignore SIGPIPE, make sure it is restored
in the child. */
- signal (SIGPIPE, SIG_DFL);
+ //signal (SIGPIPE, SIG_DFL);
#ifdef HAVE_WORKING_VFORK
sigprocmask (SIG_SETMASK, &procmask, 0);
#endif
=== modified file 'src/process.c'
--- src/process.c 2011-02-12 18:53:24 +0000
+++ src/process.c 2011-02-13 11:28:42 +0000
@@ -2056,7 +2056,7 @@
signal (SIGINT, SIG_DFL);
signal (SIGQUIT, SIG_DFL);
- /* GTK causes us to ignore SIGPIPE, make sure it is restored
+ /* GConf causes us to ignore SIGPIPE, make sure it is restored
in the child. */
signal (SIGPIPE, SIG_DFL);
I don't understand the code well enough to know how critical this is.
The comment preceding that line suggests that it could be a problem for
a build with GConf support.
Ken
next reply other threads:[~2012-05-23 15:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 15:03 Ken Brown [this message]
2012-05-23 19:50 ` bug#11547: 24.0.96; Was a line accidentally commented out in callproc.c? Jan Djärv
2012-05-23 20:10 ` Ken Brown
2012-05-24 7:01 ` Stefan Monnier
2012-05-24 11:24 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBCFC39.2090709@cornell.edu \
--to=kbrown@cornell.edu \
--cc=11547@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.