From: Davis Herring <herring@lanl.gov>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: Proposal: 'struct window' cleanup
Date: Mon, 21 May 2012 08:37:42 -0600 [thread overview]
Message-ID: <4FBA5336.8090603@lanl.gov> (raw)
In-Reply-To: <4FBA5060.7070702@yandex.ru>
> @@ -3097,14 +3096,14 @@
> {
> if (!EQ (tem, buffer))
> {
> - if (EQ (w->dedicated, Qt))
> + if (w->dedicated_p)
> /* WINDOW is strongly dedicated to its buffer, signal an
> error. */
> error ("Window is dedicated to `%s'", SDATA (BVAR (XBUFFER (tem), name)));
> else
> /* WINDOW is weakly dedicated to its buffer, reset
> dedication. */
> - w->dedicated = Qnil;
> + w->dedicated_p = 0;
>
> call1 (Qrecord_window_buffer, window);
w->dedicated is not merely a boolean, as seen here; it can be set other
than to t.
> @@ -206,11 +191,6 @@
> no scroll bar. A value of t means use frame value. */
> Lisp_Object vertical_scroll_bar_type;
>
> - /* Frame coords of mark as of last time display completed */
> - /* May be nil if mark does not exist or was not on frame */
> - Lisp_Object last_mark_x;
> - Lisp_Object last_mark_y;
> -
> /* Z - the buffer position of the last glyph in the current matrix
> of W. Only valid if WINDOW_END_VALID is not nil. */
> Lisp_Object window_end_pos;
I guess these weren't used at all? They were never booleans.
Davis
--
This product is sold by volume, not by mass. If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.
next prev parent reply other threads:[~2012-05-21 14:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 14:25 Proposal: 'struct window' cleanup Dmitry Antipov
2012-05-21 14:37 ` Davis Herring [this message]
2012-05-22 3:30 ` Stefan Monnier
2012-05-22 7:08 ` Dmitry Antipov
2012-05-22 7:40 ` Thien-Thi Nguyen
2012-05-22 12:39 ` Stefan Monnier
2012-05-23 4:49 ` Dmitry Antipov
2012-05-23 14:23 ` Stefan Monnier
2012-06-01 3:46 ` Dmitry Antipov
2012-06-01 17:29 ` Stefan Monnier
2012-05-22 16:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBA5336.8090603@lanl.gov \
--to=herring@lanl.gov \
--cc=dmantipov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.