From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#9754: Issue with Emacs 23.4 Date: Fri, 18 May 2012 14:38:17 -0400 Message-ID: <4FB69719.4030201@cornell.edu> References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> <4FB2CFF9.70309@cs.ucla.edu> <4FB2D8AB.7030401@cornell.edu> <878vgsrpoh.fsf@Rainer.invalid> <4FB4DB2D.7040100@cornell.edu> <4FB4F27B.40508@cornell.edu> <4FB542E2.7020304@cornell.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1337366390 14943 80.91.229.3 (18 May 2012 18:39:50 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 18 May 2012 18:39:50 +0000 (UTC) Cc: 9754@debbugs.gnu.org, Achim Gratz , Paul Eggert To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 18 20:39:49 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SVS5b-0000lP-Dk for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 May 2012 20:39:47 +0200 Original-Received: from localhost ([::1]:52296 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVS5a-0007tY-Tx for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 May 2012 14:39:46 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38903) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVS5X-0007tD-BE for bug-gnu-emacs@gnu.org; Fri, 18 May 2012 14:39:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SVS5V-00077B-Ew for bug-gnu-emacs@gnu.org; Fri, 18 May 2012 14:39:42 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51792) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVS5V-000775-B1 for bug-gnu-emacs@gnu.org; Fri, 18 May 2012 14:39:41 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SVS5q-0001IO-L5 for bug-gnu-emacs@gnu.org; Fri, 18 May 2012 14:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 May 2012 18:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9754 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 9754-submit@debbugs.gnu.org id=B9754.13373663644924 (code B ref 9754); Fri, 18 May 2012 18:40:02 +0000 Original-Received: (at 9754) by debbugs.gnu.org; 18 May 2012 18:39:24 +0000 Original-Received: from localhost ([127.0.0.1]:33105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVS5C-0001HM-Ih for submit@debbugs.gnu.org; Fri, 18 May 2012 14:39:23 -0400 Original-Received: from limestone3.mail.cornell.edu ([128.253.83.163]:49986) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVS4p-0001GY-6K for 9754@debbugs.gnu.org; Fri, 18 May 2012 14:39:18 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from orchid.mail.cornell.edu (orchid.mail.cornell.edu [132.236.56.61]) by limestone3.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4IIcPV2016933 for <9754@debbugs.gnu.org>; Fri, 18 May 2012 14:38:25 -0400 (EDT) Original-Received: from authusersmtp.mail.cornell.edu (granite2.mail.cornell.edu [128.253.83.142]) by orchid.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4IIcTKZ006631 for <9754@debbugs.gnu.org>; Fri, 18 May 2012 14:38:29 -0400 (EDT) Original-Received: from [192.168.1.4] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id q4IIcRRM020694 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 18 May 2012 14:38:27 -0400 (EDT) User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 In-Reply-To: X-PMX-CORNELL-SPAM-CHECKED: Pawpaw X-PMX-Version: 5.5.9.395186, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.5.18.182718 X-Original-Sender: kbrown@cornell.edu - Fri May 18 14:38:28 2012 X-PMX-CORNELL-REASON: CU_White_List_Override X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60194 Archived-At: On 5/18/2012 2:02 PM, Stefan Monnier wrote: >> I understand, and I'm no longer proposing the patch for the emacs-24 branch. >> My question is about what should be done in the trunk. It seems to me that >> it would be better to use x_in_use, and I'm wondering if knowledgeable >> people agree. > > I do think it's better, yes. OK, thanks. Then I'll probably apply the following patch, after waiting a few days to see how a new bug in xg_select that I just reported is resolved. === modified file 'src/lisp.h' --- src/lisp.h 2012-05-09 17:51:30 +0000 +++ src/lisp.h 2012-05-18 13:38:36 +0000 @@ -3549,6 +3549,7 @@ #ifdef HAVE_X_WINDOWS /* Defined in xfns.c */ extern void syms_of_xfns (void); +extern int x_in_use; /* Defined in xsmfns.c */ extern void syms_of_xsmfns (void); === modified file 'src/xfns.c' --- src/xfns.c 2012-05-02 10:20:35 +0000 +++ src/xfns.c 2012-05-18 18:34:10 +0000 @@ -136,7 +136,7 @@ /* Nonzero if using X. */ -static int x_in_use; +int x_in_use; static Lisp_Object Qnone; static Lisp_Object Qsuppress_icon; === modified file 'src/xgselect.c' --- src/xgselect.c 2012-05-16 02:22:53 +0000 +++ src/xgselect.c 2012-05-18 18:33:23 +0000 @@ -43,7 +43,7 @@ int n_gfds = 0, our_tmo = 0, retval = 0, our_fds = 0; int i, nfds, fds_lim, tmo_in_millisec; - if (inhibit_window_system || !display_arg) + if (!x_in_use) return select (max_fds, rfds, wfds, efds, timeout); if (rfds) memcpy (&all_rfds, rfds, sizeof (all_rfds)); Ken