From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#9754: Issue with Emacs 23.4 Date: Tue, 15 May 2012 18:28:59 -0400 Message-ID: <4FB2D8AB.7030401@cornell.edu> References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> <4FB2CFF9.70309@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1337121323 19491 80.91.229.3 (15 May 2012 22:35:23 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 15 May 2012 22:35:23 +0000 (UTC) Cc: 9754@debbugs.gnu.org, "Douglas, William" To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 16 00:35:21 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SUQKu-0005l1-NM for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 May 2012 00:35:20 +0200 Original-Received: from localhost ([::1]:46332 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUQKt-00007r-St for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 May 2012 18:35:19 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:39127) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUQKp-00007W-8l for bug-gnu-emacs@gnu.org; Tue, 15 May 2012 18:35:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SUQKm-0006zK-Tg for bug-gnu-emacs@gnu.org; Tue, 15 May 2012 18:35:14 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47227) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUQFg-0005wB-3W for bug-gnu-emacs@gnu.org; Tue, 15 May 2012 18:29:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SUQFl-0000tP-Pt for bug-gnu-emacs@gnu.org; Tue, 15 May 2012 18:30:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 May 2012 22:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9754 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 9754-submit@debbugs.gnu.org id=B9754.13371209863389 (code B ref 9754); Tue, 15 May 2012 22:30:01 +0000 Original-Received: (at 9754) by debbugs.gnu.org; 15 May 2012 22:29:46 +0000 Original-Received: from localhost ([127.0.0.1]:56773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUQFV-0000sb-5Z for submit@debbugs.gnu.org; Tue, 15 May 2012 18:29:45 -0400 Original-Received: from limestone8.mail.cornell.edu ([128.253.83.168]:33335) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUQFA-0000s2-AP for 9754@debbugs.gnu.org; Tue, 15 May 2012 18:29:43 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from soapstone1.mail.cornell.edu (soapstone1.mail.cornell.edu [128.253.83.143]) by limestone8.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4FMTCU1013568 for <9754@debbugs.gnu.org>; Tue, 15 May 2012 18:29:12 -0400 (EDT) Original-Received: from authusersmtp.mail.cornell.edu (granite2.mail.cornell.edu [128.253.83.142]) by soapstone1.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4FMTAOL015281; Tue, 15 May 2012 18:29:10 -0400 (EDT) Original-Received: from [192.168.1.4] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id q4FMT6GL006892 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 15 May 2012 18:29:07 -0400 (EDT) User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 In-Reply-To: <4FB2CFF9.70309@cs.ucla.edu> X-PMX-CORNELL-SPAM-CHECKED: Pawpaw X-PMX-Version: 5.5.9.395186, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.5.15.222121 X-Original-Sender: kbrown@cornell.edu - Tue May 15 18:29:08 2012 X-PMX-CORNELL-REASON: CU_White_List_Override X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60051 Archived-At: On 5/15/2012 5:51 PM, Paul Eggert wrote: > On 05/15/2012 12:08 PM, Ken Brown wrote: > >> I think this bug still exists, in slightly different form, in >> emacs-24. The call of g_main_context_query in xgselect.c:62 still >> uses the variables gfds and gfds_size, which are not initialized by >> xgselect_initialize if we're running emacs -nw. > > They are initialized to NULL and zero, which should work for > all their uses. I don't know if we can be sure of this without digging into the various GLib functions that get called in the xg_select code. I've been getting some crashes of emacs -nw on Cygwin after Cygwin's glib was updated to 2.32 a few days ago. That's what led me to start looking at xg_select. But the point is moot if we're going to apply the patch we're discussing (which gets rid of the crashes). >> more fundamentally, it doesn't make sense for emacs -nw to be interacting >> with GLib at all. I suggest the attached patch. > > That patch assumes C99's statements before declarations. > I assume the following minor rewrite of it is OK too? OK with me. Should I go ahead and apply it to the trunk? Or is it appropriate for the emacs-24 branch since it fixes a Cygwin crash? I guess that's up to Stefan and Chong, so I've added them to the CC. Ken