From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#11276: minibuffers windows can no longer explictly be resized Date: Thu, 19 Apr 2012 12:42:06 +0200 Message-ID: <4F8FEBFE.2030404@gmx.at> References: <4F8FB736.9020303@gmx.at> <9i62cw42l8.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------090109000206040001010601" X-Trace: dough.gmane.org 1334832173 10120 80.91.229.3 (19 Apr 2012 10:42:53 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 19 Apr 2012 10:42:53 +0000 (UTC) Cc: 11276@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 19 12:42:50 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SKop8-0002Ur-15 for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Apr 2012 12:42:50 +0200 Original-Received: from localhost ([::1]:52052 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SKop7-0002On-Ca for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Apr 2012 06:42:49 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52602) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SKop4-0002Of-8D for bug-gnu-emacs@gnu.org; Thu, 19 Apr 2012 06:42:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SKop2-0007a8-2a for bug-gnu-emacs@gnu.org; Thu, 19 Apr 2012 06:42:45 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39901) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SKop1-0007ZI-VW for bug-gnu-emacs@gnu.org; Thu, 19 Apr 2012 06:42:44 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SKopJ-0002jW-QD for bug-gnu-emacs@gnu.org; Thu, 19 Apr 2012 06:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Apr 2012 10:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11276 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11276-submit@debbugs.gnu.org id=B11276.133483213710451 (code B ref 11276); Thu, 19 Apr 2012 10:43:01 +0000 Original-Received: (at 11276) by debbugs.gnu.org; 19 Apr 2012 10:42:17 +0000 Original-Received: from localhost ([127.0.0.1]:40935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SKoob-0002iV-Dn for submit@debbugs.gnu.org; Thu, 19 Apr 2012 06:42:17 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.23]:48424) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1SKooY-0002iG-Sd for 11276@debbugs.gnu.org; Thu, 19 Apr 2012 06:42:16 -0400 Original-Received: (qmail invoked by alias); 19 Apr 2012 10:41:50 -0000 Original-Received: from 62-47-51-247.adsl.highway.telekom.at (EHLO [62.47.51.247]) [62.47.51.247] by mail.gmx.net (mp039) with SMTP; 19 Apr 2012 12:41:50 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18+tOkjJb8+zHKQFvc9Ib5Gi3z1YJl2hUMm/nzKGu crDXfS9xGLGAXh In-Reply-To: <9i62cw42l8.fsf@fencepost.gnu.org> X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:59251 Archived-At: This is a multi-part message in MIME format. --------------090109000206040001010601 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit > C-x ^ runs enlarge-window Silly binding. >> Does it work if you set `resize-mini-windows' to nil? > > No. First bug. I forgot that one can invoke `enlarge-window' and `shrink-window' in the minibuffer window. I'm not sure though whether these should have any effect when `resize-mini-windows' is non-nil. >> If I do that here, I can, for example, drag the divider between the >> emacs -Q main window and the minibuffer window with the mouse. > > I can't seem to do that (GNU/Linux, lucid toolkit), no matter what the > value of resize-mini-windows is. Works in 23.4, not in trunk. Second bug (though it should work with >= 2 windows). I misinterpreted the semantics of `one-window-p'. Please test the attached patch. Resizing miniwindows was hardly tested, unfortunately. martin --------------090109000206040001010601 Content-Type: text/plain; name="resize-mini-window.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="resize-mini-window.diff" === modified file 'lisp/mouse.el' --- lisp/mouse.el 2012-01-19 07:21:25 +0000 +++ lisp/mouse.el 2012-04-19 08:24:05 +0000 @@ -408,7 +408,7 @@ (and (eq line 'mode) (not resize-mini-windows) (eq (window-frame minibuffer-window) frame) - (not (one-window-p t frame)) + (not (one-window-p t)) (= (nth 1 (window-edges minibuffer-window)) (nth 3 (window-edges window))))) (which-side === modified file 'lisp/window.el' --- lisp/window.el 2012-04-11 02:36:04 +0000 +++ lisp/window.el 2012-04-19 10:22:56 +0000 @@ -2102,6 +2102,8 @@ ((zerop delta)) ((window-size-fixed-p nil horizontal) (error "Selected window has fixed size")) + ((and (window-minibuffer-p) (not horizontal)) + (window--resize-mini-window (selected-window) delta)) ((window--resizable-p nil delta horizontal) (window-resize nil delta horizontal)) (t @@ -2124,6 +2126,8 @@ ((zerop delta)) ((window-size-fixed-p nil horizontal) (error "Selected window has fixed size")) + ((and (window-minibuffer-p) (not horizontal)) + (window--resize-mini-window (selected-window) (- delta))) ((window--resizable-p nil (- delta) horizontal) (window-resize nil (- delta) horizontal)) (t --------------090109000206040001010601--