all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: rms@gnu.org
Cc: emacs-devel@gnu.org
Subject: Re: Patch to rmail.el and sendmail.el needs to go in 24.1.
Date: Wed, 18 Apr 2012 14:13:02 -0700	[thread overview]
Message-ID: <4F8F2E5E.9000005@cs.ucla.edu> (raw)
In-Reply-To: <E1SKZZU-00065h-NO@fencepost.gnu.org>

On 04/18/2012 11:25 AM, Richard Stallman wrote:
>     > Since it avoids a dangerous bug, it ought to go in 24.1.
>     > Can someone please put it there?

I tried to do that, but the patch collides with a recent
patch that was recently applied to the 24.1 branch
(please see below for a copy of the colliding patch).
Since I don't understand the code I left it alone;
perhaps you or Chong can comment when you have the time.


=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog	2012-04-15 08:49:24 +0000
+++ lisp/ChangeLog	2012-04-16 10:11:45 +0000
@@ -1,3 +1,8 @@
+2012-04-16  Chong Yidong  <cyd@gnu.org>
+
+	* mail/sendmail.el (mail-bury): Call return action with the right
+	Rmail buffer (Bug#11242).
+
 2012-04-15  Chong Yidong  <cyd@gnu.org>
 
 	* server.el (server-process-filter): Handle corner case where both

=== modified file 'lisp/mail/sendmail.el'
--- lisp/mail/sendmail.el	2012-04-03 10:21:47 +0000
+++ lisp/mail/sendmail.el	2012-04-16 10:11:45 +0000
@@ -864,7 +864,7 @@
     (unless return-action
       (dolist (buffer (buffer-list))
 	(if (eq (buffer-local-value 'major-mode buffer) 'rmail-mode)
-	    (setq return-action `(rmail-mail-return ,newbuf)))))
+	    (setq return-action `(rmail-mail-return ,buffer)))))
     (if (and (null arg) return-action)
 	(apply (car return-action) (cdr return-action))
       (switch-to-buffer newbuf))))




  parent reply	other threads:[~2012-04-18 21:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-18  1:03 Patch to rmail.el and sendmail.el needs to go in 24.1 Richard Stallman
2012-04-18  7:19 ` Andreas Schwab
2012-04-18 18:25   ` Richard Stallman
2012-04-18 20:22     ` Andreas Schwab
2012-04-18 21:13     ` Paul Eggert [this message]
2012-04-19 12:46       ` Richard Stallman
2012-04-20 19:21         ` Paul Eggert
2012-04-20 20:19           ` Glenn Morris
2012-04-20 20:45             ` Paul Eggert
2012-04-21 18:02           ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F8F2E5E.9000005@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.