From: Ken Brown <kbrown@cornell.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 10398@debbugs.gnu.org, Lars Magne Ingebrigtsen <larsi@gnus.org>
Subject: bug#10398: [PATCH] Use real vfork under Cygwin: it's fine these days
Date: Wed, 11 Apr 2012 07:15:46 -0400 [thread overview]
Message-ID: <4F8567E2.5000907@cornell.edu> (raw)
In-Reply-To: <83lim269h3.fsf@gnu.org>
On 4/11/2012 2:58 AM, Eli Zaretskii wrote:
>> From: Lars Magne Ingebrigtsen<larsi@gnus.org>
>> Cc: 10398@debbugs.gnu.org, Eli Zaretskii<eliz@gnu.org>
>> Date: Wed, 11 Apr 2012 01:26:56 +0200
>>
>> Daniel Colascione<dancol@dancol.org> writes:
>>
>>> In Cygwin 1.7, vfork is an alias for fork. The vfork the #define in
>>> cygwin.h was protecting against is gone. It's better to use vfork now
>>> so that when Cygwin gains a new, working vfork, we use it
>>> automatically.
>>
>> [...]
>>
>>> -/* vfork() interacts badly with setsid(), causing ptys to fail to
>>> - change their controlling terminal */
>>> -#define vfork fork
>>
>> Sounds sensible to me, but I'm no exactly (ahem) a Cygwin expert.
>>
>> Eli, what do you think?
>
> Not that _I_ am a Cygwin expert, but isn't it safer to do that only
> for Cygwin 1.7 and later? Ken, WDYT?
I think it's a good change. And I don't think we should make an effort
to support Cygwin versions earlier than 1.7. Cygwin 1.5 is no longer
supported by Cygwin, so I don't see a reason for emacs to try to support
it. I suspect there have been many emacs changes that are not
compatible with Cygwin 1.5.
Ken
next prev parent reply other threads:[~2012-04-11 11:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-29 14:06 bug#10398: [PATCH] Use real vfork under Cygwin: it's fine these days Daniel Colascione
2012-04-10 23:26 ` Lars Magne Ingebrigtsen
2012-04-11 6:47 ` Chong Yidong
2012-04-11 6:58 ` Eli Zaretskii
2012-04-11 11:15 ` Ken Brown [this message]
2012-04-11 11:39 ` Eli Zaretskii
2012-04-11 12:35 ` Ken Brown
2012-04-11 19:26 ` Eli Zaretskii
2012-04-12 2:51 ` Ken Brown
2012-04-12 4:53 ` Glenn Morris
2012-04-12 6:00 ` Eli Zaretskii
2012-04-12 7:40 ` Andreas Schwab
2012-04-12 12:21 ` Ken Brown
2012-04-11 17:48 ` Drew Adams
2012-04-11 19:37 ` Ken Brown
2012-04-11 20:04 ` Drew Adams
2012-04-11 11:44 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8567E2.5000907@cornell.edu \
--to=kbrown@cornell.edu \
--cc=10398@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.