all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: Albert <ab.for.lists@gmail.com>, 10729@debbugs.gnu.org
Subject: bug#10729: 24.0.93; On MS-Windows: emacsclientw.exe -n -c does create a new frame, but does not always display the requested file or the requested directory (24.0.92 does)
Date: Tue, 07 Feb 2012 15:32:33 +0100	[thread overview]
Message-ID: <4F313601.6080604@gmx.at> (raw)
In-Reply-To: <CAAeL0SQqc=VHFzwn2voceXd-63gM+F9fR4DhtekeNu6vjYD0Bw@mail.gmail.com>

 > Or, assuming I'm now really awake, this one.

I'd rather use something like the untested patch below (still very fragile
because it neither verifies that a frame is a frame nor that a buffer is
a buffer).

martin


=== modified file 'lisp/server.el'
*** lisp/server.el	2012-02-02 07:48:39 +0000
--- lisp/server.el	2012-02-07 14:29:08 +0000
***************
*** 399,414 ****
       ;; visible.  If not (which can happen if the user's customizations call
       ;; pop-to-buffer etc.), delete it to avoid preserving the connection after
       ;; the last real frame is deleted.
!     (if (and (eq (frame-first-window frame)
!                  (next-window (frame-first-window frame) 'nomini))
!              (eq (window-buffer (frame-first-window frame))
!                  (frame-parameter frame 'server-dummy-buffer)))
!         ;; The temp frame still only shows one buffer, and that is the
!         ;; internal temp buffer.
!         (delete-frame frame)
!       (set-frame-parameter frame 'visibility t))
!     (kill-buffer (frame-parameter frame 'server-dummy-buffer))
!     (set-frame-parameter frame 'server-dummy-buffer nil)))

   (defun server-handle-delete-frame (frame)
     "Delete the client connection when the emacsclient frame is deleted.
--- 399,413 ----
       ;; visible.  If not (which can happen if the user's customizations call
       ;; pop-to-buffer etc.), delete it to avoid preserving the connection after
       ;; the last real frame is deleted.
!     (let ((buffer (frame-parameter frame 'server-dummy-buffer)))
!       (if (and (one-window-p 'nomini frame)
! 	       (eq (window-buffer (frame-first-window frame)) buffer))
! 	  ;; The temp frame still only shows one buffer, and that is the
! 	  ;; internal temp buffer.
! 	  (delete-frame frame)
! 	(set-frame-parameter frame 'visibility t)
! 	(set-frame-parameter frame 'server-dummy-buffer nil))
!       (kill-buffer buffer))))

   (defun server-handle-delete-frame (frame)
     "Delete the client connection when the emacsclient frame is deleted.






  reply	other threads:[~2012-02-07 14:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-04 23:41 bug#10729: 24.0.93; On MS-Windows: emacsclientw.exe -n -c does create a new frame, but does not always display the requested file or the requested directory (24.0.92 does) Albert
2012-02-05 15:48 ` Juanma Barranquero
2012-02-06 17:03   ` Juanma Barranquero
2012-02-06 17:47     ` Albert
2012-02-06 21:06       ` Juanma Barranquero
2012-02-06 17:57     ` martin rudalics
2012-02-06 21:11       ` Juanma Barranquero
2012-02-07  7:53         ` martin rudalics
2012-02-07 13:08           ` Juanma Barranquero
2012-02-07 13:31             ` Juanma Barranquero
2012-02-07 13:33               ` Juanma Barranquero
2012-02-07 14:32                 ` martin rudalics [this message]
2012-02-07 14:35                   ` Juanma Barranquero
2012-02-07 15:21                     ` martin rudalics
2012-02-07 15:28                       ` Juanma Barranquero
2012-02-07 17:05                         ` martin rudalics
2012-02-07 17:27                   ` Stefan Monnier
2012-02-08 12:24                     ` Juanma Barranquero
2012-02-07 15:22             ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F313601.6080604@gmx.at \
    --to=rudalics@gmx.at \
    --cc=10729@debbugs.gnu.org \
    --cc=ab.for.lists@gmail.com \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.