all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Christoph Scholtes <cschol2112@googlemail.com>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 9750@debbugs.gnu.org
Subject: bug#9750: 24.0.90; Windows binary distribution build fails with 24.0.90 Pretest
Date: Sat, 04 Feb 2012 16:23:00 -0700	[thread overview]
Message-ID: <4F2DBDD4.1020702@gmail.com> (raw)
In-Reply-To: <jwvboteti9h.fsf-monnier+emacs@gnu.org>

On 10/18/2011 9:47 AM, Stefan Monnier wrote:
>> It seems this change was made over a year ago, but a few months later
>> make-dist was changed to explicitly exclude this file. The question mark
>> on the end of the comment seems to indicate that the author of the
>> change wasn't sure at the time if it was the right thing to do.
>
> Please just move the file to `nt', and rework the first few sentences to
> make it clear in which context it is meant to be used.

Here is a proposed change to make the intent of the README.W32 file 
clearer if it comes in the Emacs sources distribution. The change to 
make-dist includes the file again in the source tarball. The fact that 
it does not right now is a major pain when trying to automate building 
the distribution from a source tarball.

Christoph

=== modified file 'nt/README.W32'
--- nt/README.W32	2012-01-26 21:37:32 +0000
+++ nt/README.W32	2012-02-04 23:19:02 +0000
@@ -3,9 +3,15 @@

  			   Emacs for Windows

-  This README file describes how to set up and run a precompiled
-  version of GNU Emacs for Windows.  This distribution can be found on
-  the ftp.gnu.org server and its mirrors:
+  This README.W32 file describes how to set up and run a precompiled
+  version of GNU Emacs for Windows.
+
+  Please note that if you have received this file as part of the Emacs
+  source distribution see the included README file on how to compile
+  Emacs for Windows.
+
+  This distribution can be found on the ftp.gnu.org server and its
+  mirrors:

  	ftp://ftp.gnu.org/gnu/emacs/windows/


=== modified file 'make-dist'
--- make-dist	2012-01-19 07:21:25 +0000
+++ make-dist	2012-02-04 23:16:36 +0000
@@ -398,13 +398,12 @@
  (cd m4
   ln *.m4 ../${tempdir}/m4)

-## Exclude README.W32 because it is specific to pre-built binaries(?).
  echo "Making links to \`nt'"
  (cd nt
   ln emacs.manifest emacs.rc emacsclient.rc config.nt ../${tempdir}/nt
   ln emacs-src.tags nmake.defs gmake.defs subdirs.el ../${tempdir}/nt
   ln [a-z]*.bat [a-z]*.[ch] ../${tempdir}/nt
- ln ChangeLog INSTALL README makefile.w32-in ../${tempdir}/nt)
+ ln ChangeLog INSTALL README README.W32 makefile.w32-in ../${tempdir}/nt)

  echo "Making links to \`nt/inc' and its subdirectories"
  for f in `find nt/inc -type f -name '[a-z]*.h'`; do







  parent reply	other threads:[~2012-02-04 23:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-14  3:22 bug#9750: 24.0.90; Windows binary distribution build fails with 24.0.90 Pretest Christoph Scholtes
2011-10-18  7:39 ` Glenn Morris
2011-10-18 14:18   ` Jason Rumney
2011-10-18 14:34     ` Jason Rumney
2011-10-18 15:47       ` Stefan Monnier
2011-10-19  1:15         ` Christoph Scholtes
2012-02-04 23:23         ` Christoph Scholtes [this message]
2012-02-05 16:45           ` Eli Zaretskii
2012-02-05 18:18             ` Christoph Scholtes
2012-02-05 21:01             ` Christoph Scholtes
2011-10-19  1:01   ` Christoph Scholtes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F2DBDD4.1020702@gmail.com \
    --to=cschol2112@googlemail.com \
    --cc=9750@debbugs.gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.