From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] windmove.el: Fix windmove-reference-loc miscalculation Date: Fri, 20 Jan 2012 19:07:51 +0100 Message-ID: <4F19AD77.5000705@gmx.at> References: <87wr8ntkxb.fsf@Apollo.jerryland.fr> <4F193B95.5000808@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1327082891 20570 80.91.229.12 (20 Jan 2012 18:08:11 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 20 Jan 2012 18:08:11 +0000 (UTC) Cc: Sylvain Rousseau , emacs-devel@gnu.org To: =?ISO-8859-1?Q?J=E9r=E9my_Compostella?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 20 19:08:07 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RoIsf-0000FX-RY for ged-emacs-devel@m.gmane.org; Fri, 20 Jan 2012 19:08:05 +0100 Original-Received: from localhost ([::1]:44469 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RoIsf-0008Vt-Bs for ged-emacs-devel@m.gmane.org; Fri, 20 Jan 2012 13:08:05 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:44209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RoIsX-0008Ua-TT for emacs-devel@gnu.org; Fri, 20 Jan 2012 13:08:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RoIsW-0002vo-Ph for emacs-devel@gnu.org; Fri, 20 Jan 2012 13:07:57 -0500 Original-Received: from mailout-de.gmx.net ([213.165.64.23]:35320) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1RoIsW-0002vj-DM for emacs-devel@gnu.org; Fri, 20 Jan 2012 13:07:56 -0500 Original-Received: (qmail invoked by alias); 20 Jan 2012 18:07:55 -0000 Original-Received: from 62-47-39-87.adsl.highway.telekom.at (EHLO [62.47.39.87]) [62.47.39.87] by mail.gmx.net (mp011) with SMTP; 20 Jan 2012 19:07:55 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+hWMYO1iOhpLoFCNW9yrAMkGY2osfels8brEpoek Rwemovf01tamLo In-Reply-To: X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 213.165.64.23 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:147785 Archived-At: > Effectively the issue is only windmove.el related. So IIUC the issue is that `windmove-reference-loc' (windmove-coord-add top-left (let ((col-row (posn-col-row (posn-at-point (window-point window) window)))) (cons (- (car col-row) (window-hscroll window)) (cdr col-row))))))))) wrongly subtracts the value returned by `window-hscroll' from a column value correctly calculated by `posn-at-point' (window_box_left_offset)? In this case I think your patch is correct. martin