From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] window.el: Improve mark management Date: Fri, 20 Jan 2012 11:01:49 +0100 Message-ID: <4F193B8D.9070209@gmx.at> References: <87zkdjtr4v.fsf@Apollo.jerryland.fr> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1327053729 11928 80.91.229.12 (20 Jan 2012 10:02:09 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 20 Jan 2012 10:02:09 +0000 (UTC) Cc: emacs-devel@gnu.org To: =?UTF-8?B?SsOpcsOpbXkgQ29tcG9zdGVsbGE=?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 20 11:02:06 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RoBIK-0000B7-Po for ged-emacs-devel@m.gmane.org; Fri, 20 Jan 2012 11:02:05 +0100 Original-Received: from localhost ([::1]:46993 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RoBIK-0000h7-9p for ged-emacs-devel@m.gmane.org; Fri, 20 Jan 2012 05:02:04 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:59125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RoBIE-0000f6-6w for emacs-devel@gnu.org; Fri, 20 Jan 2012 05:02:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RoBI9-0002HM-MN for emacs-devel@gnu.org; Fri, 20 Jan 2012 05:01:58 -0500 Original-Received: from mailout-de.gmx.net ([213.165.64.23]:50249) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1RoBI9-0002GU-0W for emacs-devel@gnu.org; Fri, 20 Jan 2012 05:01:53 -0500 Original-Received: (qmail invoked by alias); 20 Jan 2012 10:01:50 -0000 Original-Received: from 62-47-50-127.adsl.highway.telekom.at (EHLO [62.47.50.127]) [62.47.50.127] by mail.gmx.net (mp011) with SMTP; 20 Jan 2012 11:01:50 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/tk3s7RYvtL/eClH/RGjx9rCqu0UUIjaFmQwyNto KNiG5xA9TxGRkQ In-Reply-To: <87zkdjtr4v.fsf@Apollo.jerryland.fr> X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 213.165.64.23 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:147763 Archived-At: > First, `mark-active' save was missing in the `window-state-get' > function. Second, `window-state-put' restore the mark without taking > into account the previously set mark(s). It looks better to use > `push-mark' instead of `set-mark'. Moreover it does not restore the > active mark state which lead to an automatically active mark in > restored buffer. > > Please, review it or merge it, Looks good to me. I shall install this in a couple of days if no one objects. Thanks, martin