From: martin rudalics <rudalics@gmx.at>
To: "Jérémy Compostella" <jeremy.compostella@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] window.el: Improve mark management
Date: Fri, 20 Jan 2012 11:01:49 +0100 [thread overview]
Message-ID: <4F193B8D.9070209@gmx.at> (raw)
In-Reply-To: <87zkdjtr4v.fsf@Apollo.jerryland.fr>
> First, `mark-active' save was missing in the `window-state-get'
> function. Second, `window-state-put' restore the mark without taking
> into account the previously set mark(s). It looks better to use
> `push-mark' instead of `set-mark'. Moreover it does not restore the
> active mark state which lead to an automatically active mark in
> restored buffer.
>
> Please, review it or merge it,
Looks good to me.
I shall install this in a couple of days if no one objects.
Thanks, martin
next prev parent reply other threads:[~2012-01-20 10:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 19:43 [PATCH] window.el: Improve mark management Jérémy Compostella
2012-01-20 10:01 ` martin rudalics [this message]
2012-01-20 13:42 ` Stefan Monnier
2012-01-20 15:13 ` martin rudalics
2012-01-20 16:11 ` Stefan Monnier
2012-01-20 16:52 ` Jérémy Compostella
2012-01-20 18:25 ` Stefan Monnier
2012-01-21 14:36 ` Jérémy Compostella
2012-01-24 20:31 ` Stefan Monnier
2012-01-25 10:32 ` martin rudalics
2012-01-25 13:45 ` Stefan Monnier
2012-01-25 15:01 ` Jérémy Compostella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F193B8D.9070209@gmx.at \
--to=rudalics@gmx.at \
--cc=emacs-devel@gnu.org \
--cc=jeremy.compostella@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.