* [xterm.h] note on 'dragging' field of 'struct scroll_bar'
@ 2012-01-10 13:58 Dmitry Antipov
0 siblings, 0 replies; only message in thread
From: Dmitry Antipov @ 2012-01-10 13:58 UTC (permalink / raw)
To: emacs-devel
I want to notice about the placement of 'dragging' field within 'struct scroll_bar'.
It's a Lisp_Object, but placed so it's not reachable by the marking traversal. IIUC,
it works just because it's always an integer, Qnil or Qt; but this is a potential trap
for someone who will change this someday. So, I think it's better to use plain C 'int'
instead, or move 'dragging' up to the head of 'struct scroll_bar' before 'x_window'.
And, the more general question is: why not use the same 'struct scroll_bar' both for
X and Win32 code?
Dmitry
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-01-10 13:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-10 13:58 [xterm.h] note on 'dragging' field of 'struct scroll_bar' Dmitry Antipov
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.