all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Antipov <dmantipov@yandex.ru>
To: emacs-devel@gnu.org
Subject: [xterm.h] note on 'dragging' field of 'struct scroll_bar'
Date: Tue, 10 Jan 2012 17:58:01 +0400	[thread overview]
Message-ID: <4F0C43E9.3060300@yandex.ru> (raw)

I want to notice about the placement of 'dragging' field within 'struct scroll_bar'.
It's a Lisp_Object, but placed so it's not reachable by the marking traversal. IIUC,
it works just because it's always an integer, Qnil or Qt; but this is a potential trap
for someone who will change this someday. So, I think it's better to use plain C 'int'
instead, or move 'dragging' up to the head of 'struct scroll_bar' before 'x_window'.

And, the more general question is: why not use the same 'struct scroll_bar' both for
X and Win32 code?

Dmitry



                 reply	other threads:[~2012-01-10 13:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F0C43E9.3060300@yandex.ru \
    --to=dmantipov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.