From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 2/4] Refactor window-system configuration Date: Thu, 29 Dec 2011 14:48:57 -0800 Message-ID: <4EFCEE59.7030605@dancol.org> References: <4b98eec4a5f68bfcd9233d5e7444de05873225b4.1325166472.git.dancol@dancol.org> <4EFCE9C4.8050908@dancol.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig319644AF003BD94B8E51E3B3" X-Trace: dough.gmane.org 1325198955 17255 80.91.229.12 (29 Dec 2011 22:49:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 29 Dec 2011 22:49:15 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 29 23:49:11 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RgOmd-0004aZ-6e for ged-emacs-devel@m.gmane.org; Thu, 29 Dec 2011 23:49:11 +0100 Original-Received: from localhost ([::1]:52220 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgOmc-000285-Om for ged-emacs-devel@m.gmane.org; Thu, 29 Dec 2011 17:49:10 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:51854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgOmZ-00027n-Va for emacs-devel@gnu.org; Thu, 29 Dec 2011 17:49:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RgOmZ-0007k8-3t for emacs-devel@gnu.org; Thu, 29 Dec 2011 17:49:07 -0500 Original-Received: from dancol.org ([96.126.100.184]:34718) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgOmX-0007ju-Cj; Thu, 29 Dec 2011 17:49:05 -0500 Original-Received: from c-24-18-179-193.hsd1.wa.comcast.net ([24.18.179.193] helo=edith.local) by dancol.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1RgOmW-0008Nm-8g; Thu, 29 Dec 2011 14:49:04 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:8.0) Gecko/20111105 Thunderbird/8.0 In-Reply-To: X-Enigmail-Version: 1.3.4 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 96.126.100.184 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:147019 Archived-At: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig319644AF003BD94B8E51E3B3 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 12/29/11 2:43 PM, Dan Nicolaescu wrote: > Daniel Colascione writes: >=20 >> On 12/29/11 2:21 PM, Dan Nicolaescu wrote: >>> We don't use something like "#include TERM_HEADER" in any other place= , >>> it you really want to consolidate this stuff, creating a new header >>> file to include seems better. >> >> There's a first time for everything, and besides: other projects have >=20 > Why add another wrinkle when we have perfectly working solutions alread= y?=20 We don't have a working solution. We have a mess, and we're trying to clean it up. Sure, we don't have header constants right now, but we don't have any pure-dispatch headers either. I suppose we disagree on what counts as a wrinkle. In my mind, it's simpler for config.h to just tell code what header to include than to create (and maintain) a header file that consists solely of ifdefs and more includes. Ideally, we'd not include window-system-specific headers at all, instead getting at this functionality via function pointers in a generic struct in frame.h. But for that, I'd have to change more code than I want to right now, and this approach gets us 80% there. --------------enig319644AF003BD94B8E51E3B3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (Darwin) Comment: GPGTools - http://gpgtools.org iEYEARECAAYFAk787loACgkQ17c2LVA10Vt2MACePJWuOelbiKOixc40HYpcIIvV HvAAoLhtAVXCrc1JtfX1XYzylCuPL3oo =pntW -----END PGP SIGNATURE----- --------------enig319644AF003BD94B8E51E3B3--