From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 2/4] Refactor window-system configuration Date: Thu, 29 Dec 2011 14:29:24 -0800 Message-ID: <4EFCE9C4.8050908@dancol.org> References: <4b98eec4a5f68bfcd9233d5e7444de05873225b4.1325166472.git.dancol@dancol.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigA60175142B566078B2F9ED5C" X-Trace: dough.gmane.org 1325197782 10558 80.91.229.12 (29 Dec 2011 22:29:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 29 Dec 2011 22:29:42 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 29 23:29:38 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RgOTi-0006NP-IN for ged-emacs-devel@m.gmane.org; Thu, 29 Dec 2011 23:29:38 +0100 Original-Received: from localhost ([::1]:58513 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgOTh-0006KQ-Uj for ged-emacs-devel@m.gmane.org; Thu, 29 Dec 2011 17:29:37 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:57231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgOTe-0006KI-J9 for emacs-devel@gnu.org; Thu, 29 Dec 2011 17:29:35 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RgOTd-0005Ej-6c for emacs-devel@gnu.org; Thu, 29 Dec 2011 17:29:34 -0500 Original-Received: from dancol.org ([96.126.100.184]:34665) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgOTb-0005EG-Pa; Thu, 29 Dec 2011 17:29:31 -0500 Original-Received: from c-24-18-179-193.hsd1.wa.comcast.net ([24.18.179.193] helo=edith.local) by dancol.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1RgOTa-0008M9-3b; Thu, 29 Dec 2011 14:29:30 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:8.0) Gecko/20111105 Thunderbird/8.0 In-Reply-To: X-Enigmail-Version: 1.3.4 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 96.126.100.184 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:147017 Archived-At: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigA60175142B566078B2F9ED5C Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 12/29/11 2:21 PM, Dan Nicolaescu wrote: > We don't use something like "#include TERM_HEADER" in any other place, > it you really want to consolidate this stuff, creating a new header > file to include seems better. There's a first time for everything, and besides: other projects have successfully used this approach. My initial revisions actually did exactly what you suggest, but I realized that the solution was more complex and didn't actually have any benefit. Besides, we have src/s/*.h and src/m/*.h. At least this approach is explicit. > Also "TERM" does not look like a good prefix > in this case, it's meaning might be confused with the TERM environment > variable (nsterm/w32term/xterm are not that great either, but better no= t > propagate the confusion). "Term", I think, it pretty clear in the context of Emacs. Using a different name for the header constant wouldn't change the names of all the datatypes in that header. It's better to at least be consistently confusing. There's XTERM_HEADER, but this name has other issues. --------------enigA60175142B566078B2F9ED5C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (Darwin) Comment: GPGTools - http://gpgtools.org iEYEARECAAYFAk786cQACgkQ17c2LVA10Vul2ACgjavW/FaQDTJi4uZMQm6W6C7D IPkAn24UCDqsBLQ2jXj7Za3yOTcAlSz7 =Rljm -----END PGP SIGNATURE----- --------------enigA60175142B566078B2F9ED5C--