From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 4/4] Fix emacsclient to work with cygw32 Date: Thu, 29 Dec 2011 09:56:43 -0800 Message-ID: <4EFCA9DB.3030002@dancol.org> References: <3a4c4669da1d97d72975e8943d7b8edff22427c1.1325166472.git.dancol@dancol.org> <83mxabuvj2.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig07BE556FA65F55F1DA90FFC9" X-Trace: dough.gmane.org 1325181417 2757 80.91.229.12 (29 Dec 2011 17:56:57 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 29 Dec 2011 17:56:57 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 29 18:56:53 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RgKDk-000388-LQ for ged-emacs-devel@m.gmane.org; Thu, 29 Dec 2011 18:56:52 +0100 Original-Received: from localhost ([::1]:60354 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgKDk-0004gT-AS for ged-emacs-devel@m.gmane.org; Thu, 29 Dec 2011 12:56:52 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:38266) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgKDg-0004fh-RN for emacs-devel@gnu.org; Thu, 29 Dec 2011 12:56:49 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RgKDf-0000M8-KI for emacs-devel@gnu.org; Thu, 29 Dec 2011 12:56:48 -0500 Original-Received: from dancol.org ([96.126.100.184]:34194) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgKDe-0000LP-7S; Thu, 29 Dec 2011 12:56:46 -0500 Original-Received: from c-24-18-179-193.hsd1.wa.comcast.net ([24.18.179.193] helo=[192.168.1.2]) by dancol.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1RgKDd-00086B-DH; Thu, 29 Dec 2011 09:56:45 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:8.0) Gecko/20111105 Thunderbird/8.0 In-Reply-To: <83mxabuvj2.fsf@gnu.org> X-Enigmail-Version: 1.3.4 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 96.126.100.184 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:147008 Archived-At: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig07BE556FA65F55F1DA90FFC9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/29/11 9:39 AM, Eli Zaretskii wrote: >> Date: Thu, 29 Dec 2011 06:03:20 -0800 >> From: Daniel Colascione >> >> @@ -184,7 +188,7 @@ struct option longopts[] =3D >> { "socket-name", required_argument, NULL, 's' }, >> #endif >> { "server-file", required_argument, NULL, 'f' }, >> -#ifndef WINDOWSNT >> +#ifndef HAVE_NTGUI >> { "display", required_argument, NULL, 'd' }, >> #endif >=20 > Maybe I'm confused: will HAVE_NTGUI be applicable to the Cygwin build > that can use the w32 windowing? If so, it sounds like you are > creating here 2 kinds of emacsclient: one that can talk to a Cygwin > Emacs with X frames on another display, the other that cannot. Why > cannot the same emacsclient work with both types of Emacs frames in a > Cygwin Emacs? >=20 > Apologies if I've misread the changes. No, you're right. I was following the template of the existing code here; IIUC, removing the conditional in the hunk above will let the same emacsclient talk to any kind of Emacs. --------------enig07BE556FA65F55F1DA90FFC9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (Darwin) Comment: GPGTools - http://gpgtools.org iEYEARECAAYFAk78qdsACgkQ17c2LVA10VuPTQCgv+Bg6dhJ3oGTyatWo967fOjZ b7EAniFMMmLsqLM2lcvtOK1EIZHdH3oa =J5Lb -----END PGP SIGNATURE----- --------------enig07BE556FA65F55F1DA90FFC9--