From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 1/4] Compilation cleanups Date: Thu, 29 Dec 2011 09:54:19 -0800 Organization: UCLA Computer Science Department Message-ID: <4EFCA94B.9020502@cs.ucla.edu> References: <0c9938df7c6041c406017cec0d16691d46d017f8.1325166472.git.dancol@dancol.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1325181272 1597 80.91.229.12 (29 Dec 2011 17:54:32 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 29 Dec 2011 17:54:32 +0000 (UTC) Cc: emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 29 18:54:28 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RgKBO-0001Ct-OO for ged-emacs-devel@m.gmane.org; Thu, 29 Dec 2011 18:54:26 +0100 Original-Received: from localhost ([::1]:58632 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgKBO-0003w3-1x for ged-emacs-devel@m.gmane.org; Thu, 29 Dec 2011 12:54:26 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:37805) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgKBL-0003vo-CH for emacs-devel@gnu.org; Thu, 29 Dec 2011 12:54:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RgKBJ-0008Em-LH for emacs-devel@gnu.org; Thu, 29 Dec 2011 12:54:23 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:48807) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgKBJ-0008EO-Fa for emacs-devel@gnu.org; Thu, 29 Dec 2011 12:54:21 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 702ABA60008; Thu, 29 Dec 2011 09:54:20 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mkTlfFVX12ZR; Thu, 29 Dec 2011 09:54:19 -0800 (PST) Original-Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id B1575A60007; Thu, 29 Dec 2011 09:54:19 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:8.0) Gecko/20111124 Thunderbird/8.0 In-Reply-To: <0c9938df7c6041c406017cec0d16691d46d017f8.1325166472.git.dancol@dancol.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:147007 Archived-At: On 12/29/11 06:03, Daniel Colascione wrote: > --- a/lib-src/update-game-score.c > +++ b/lib-src/update-game-score.c > @@ -48,8 +48,10 @@ along with GNU Emacs. If not, see . */ > #include > > /* Needed for SunOS4, for instance. */ > +#if !defined(CYGWIN) > extern char *optarg; > extern int optind, opterr; > +#endif // !defined(CYGWIN) I suggest replacing those lines with "#include " instead; that's what the other .c files do, and it's cleaner. > --- a/src/gmalloc.c > +++ b/src/gmalloc.c ... > - if (ptr < _heapbase) > + if ((char*)ptr < (char*)_heapbase) No need to cast _heapbase as it's already a char *. And please put a space after the ')', e.g., "(char*) ptr < _heapbase", as that's the usual Emacs style.