From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 4/4] Fix emacsclient to work with cygw32 Date: Thu, 29 Dec 2011 08:36:38 -0800 Message-ID: <4EFC9716.3050209@dancol.org> References: <3a4c4669da1d97d72975e8943d7b8edff22427c1.1325166472.git.dancol@dancol.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigD3019616E87F64AE4B8D5BAD" X-Trace: dough.gmane.org 1325176623 2636 80.91.229.12 (29 Dec 2011 16:37:03 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 29 Dec 2011 16:37:03 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 29 17:36:59 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RgIyR-0007Ov-1t for ged-emacs-devel@m.gmane.org; Thu, 29 Dec 2011 17:36:59 +0100 Original-Received: from localhost ([::1]:50456 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgIyQ-0004pd-B2 for ged-emacs-devel@m.gmane.org; Thu, 29 Dec 2011 11:36:58 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:38741) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgIyN-0004pE-QY for emacs-devel@gnu.org; Thu, 29 Dec 2011 11:36:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RgIyH-0002P3-PW for emacs-devel@gnu.org; Thu, 29 Dec 2011 11:36:55 -0500 Original-Received: from dancol.org ([96.126.100.184]:34055) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgIyH-0002Ou-LE for emacs-devel@gnu.org; Thu, 29 Dec 2011 11:36:49 -0500 Original-Received: from c-24-18-179-193.hsd1.wa.comcast.net ([24.18.179.193] helo=[192.168.1.2]) by dancol.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1RgIyF-00080T-UM; Thu, 29 Dec 2011 08:36:48 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:8.0) Gecko/20111105 Thunderbird/8.0 In-Reply-To: X-Enigmail-Version: 1.3.4 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 96.126.100.184 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:146999 Archived-At: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigD3019616E87F64AE4B8D5BAD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/29/11 8:28 AM, Juanma Barranquero wrote: > On Thu, Dec 29, 2011 at 15:03, Daniel Colascione wr= ote: >=20 >> - ;; On Windows, emacsclient always asks for a tty fra= me. >> - ;; If running a GUI server, force the frame type to = GUI. >> - (when (eq window-system 'w32) >> + ;; On Windows, emacsclient always asks for a tty >> + ;; frame. If running a GUI server, force the frame >> + ;; type to GUI. (Cygwin is perfectly happy with >> + ;; multi-tty support, so don't override the user's >> + ;; choice there.) >> + (when (and (eq system-type 'windows-nt) >> + (eq window-system 'w32)) This hunk narrows the scope of a windows-nt special case so that it doesn't apply to Cygwin. > Don't you need to fix also this? >=20 > ;; Delete the client's tty, except on Windows (both GUI and conso= le), > ;; where there's only one terminal and does not make sense to del= ete it. > (unless (eq system-type 'windows-nt) > (let ((terminal (process-get proc 'terminal))) > ;; Only delete the terminal if it is non-nil. > (when (and terminal (eq (terminal-live-p terminal) t)) > (delete-terminal terminal)))) >=20 > Juanma >=20 No --- a Cygwin tty acts like a tty on any other unix, so we don't want to treat it specially. The comment refers to native Windows consoles onl= y. --------------enigD3019616E87F64AE4B8D5BAD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (Darwin) Comment: GPGTools - http://gpgtools.org iEYEARECAAYFAk78lxgACgkQ17c2LVA10VszBQCcDsTq0U3OWhSP4xVoy3u6b1cK aLoAoKzus3cXh0AHg5LA9ScJ/rrbSzzT =N2dP -----END PGP SIGNATURE----- --------------enigD3019616E87F64AE4B8D5BAD--