From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Caldwell Newsgroups: gmane.emacs.bugs Subject: bug#9960: "emacsclient.c (main) : Remove declaration, " breaks build on Mac OS X Date: Mon, 28 Nov 2011 01:34:48 -0800 Message-ID: <4ED355B8.60006@porkrind.org> References: <8339e2lsu7.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig84A5328419A1DF51140B0234" X-Trace: dough.gmane.org 1322472930 11425 80.91.229.12 (28 Nov 2011 09:35:30 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 28 Nov 2011 09:35:30 +0000 (UTC) Cc: 9960@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 28 10:35:25 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RUxcS-0003K0-Nt for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Nov 2011 10:35:25 +0100 Original-Received: from localhost ([::1]:48516 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RUxcQ-0008Fd-0J for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Nov 2011 04:35:22 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:55827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RUxcH-0008FT-HX for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2011 04:35:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RUxcD-0000wq-Pl for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2011 04:35:13 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40418) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RUxcD-0000wN-LM for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2011 04:35:09 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RUxe2-0004dN-7K for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2011 04:37:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <8339e2lsu7.fsf@gnu.org> Resent-From: David Caldwell Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Nov 2011 09:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9960 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: Original-Received: via spool by 9960-submit@debbugs.gnu.org id=B9960.132247301817803 (code B ref 9960); Mon, 28 Nov 2011 09:37:02 +0000 Original-Received: (at 9960) by debbugs.gnu.org; 28 Nov 2011 09:36:58 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RUxdx-0004d5-Px for submit@debbugs.gnu.org; Mon, 28 Nov 2011 04:36:58 -0500 Original-Received: from sa38.galvanix.net ([98.126.48.38] helo=kill.porkrind.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RUxdt-0004cv-02 for 9960@debbugs.gnu.org; Mon, 28 Nov 2011 04:36:55 -0500 Original-Received: from porkrind.org (cpe-66-74-178-118.socal.res.rr.com [66.74.178.118]) by kill.porkrind.org (Postfix) with ESMTPS id B57A95F11C; Mon, 28 Nov 2011 01:34:54 -0800 (PST) Authentication-Results: kill.porkrind.org; dkim=pass (1536-bit key; insecure key) header.i=@porkrind.org header.b=PcaK+4ne; dkim-adsp=pass Received-SPF: pass (porkrind.org: authenticated connection) receiver=porkrind.org; client-ip=127.0.0.1; helo=black.porkrind.org; envelope-from=david@porkrind.org; x-software=spfmilter 0.97 http://www.acme.com/software/spfmilter/ with libspf-unknown; Original-Received: from black.porkrind.org (localhost [127.0.0.1]) (authenticated bits=0) by porkrind.org (8.14.4/8.14.4/Debian-2) with ESMTP id pAS9Yrme010346 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NOT); Mon, 28 Nov 2011 01:34:53 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=porkrind.org; s=apoptygma; t=1322472895; bh=ccP9JyoyUbCegnblFIMjfnY04TCPzb+Q5Ez7aPisPtg=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:Content-Type; b=PcaK+4neKqruhw0ueWUZ6nxjCHFc7rnRdMQ1McRc57tKVhB0En0Mw3bQbIr1AHl53 J87juvnc4WFdAUdF7OnDzKFgwNsDVqLxV6pT8daMsobZPzNwDxl/7DA2BICp13ssTV JduulNL/nbgFPSUHzhs3zncqgDBsiZQ8UaTYZwnT1994dwgOMm/4RpgQfMRnLBCtUP 9x5Dk6UwqQrlqPQ3rwfgL57N95VGOSz63FXzqfwrT2Jff6o4sCmhHUn+1sr User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:8.0) Gecko/20111105 Thunderbird/8.0 X-Enigmail-Version: 1.3.3 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAQAAAD9CzEMAAAACXBIWXMAAAsTAAALEwEAmpwY AAAABGdBTUEAALGOfPtRkwAAACBjSFJNAAB6JQAAgIMAAPn/AACA6QAAdTAAAOpgAAA6mAAAF2+S X8VGAAABiklEQVR42rRYSZIDIQwzLv7/ZXLoEAzeBKG7ag4DRhZeBKQ0Qr5imLWCrKwn0HImc1Mx aAvmmc/cuAT7RMYws6v/gHeb0p4/y5792GJJlLZWOPgsdV5NaRes4Xe4632sLljD7wKv1Ta74H/h MxecN1Rc2TatYcP7zb+6WFfN/zMSHg1Ymuxjrzd+DuLw6Nlekggt1hvr7KK9tRIX85jjM6GTYhfv nzXH3jBdYc4koueBs66M+Xv9O9n5ML4urWssjGeMY3if3bzGSvk30BQ46OOaxJjLCpzPJAzXrOrD z5VFh58TIiwESIiCHNxxwPTy97qDei8YdpVdyYEv6EQcK8n+iTyE/Cn1eoe7HwN+F56oErVSGtJY Q1sR2ehaUHfjvJuv0tL7qAzEbBmfF2IHrVi8zp9N0pZtQZZHOXp/sLW4+hqKvm3iccaPwP3XgnKX n8/YtVeOsnenRG7VCBFlZ5fe3LOyANCVdGAIwDs7tTXGF4hIk15/iAfSgv2UkNFItSszOG3Ha7r0 GQBerhBkHOAzmQAAAABJRU5ErkJggg== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 28 Nov 2011 04:37:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:54349 Archived-At: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig84A5328419A1DF51140B0234 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable FYI, I get this error when compiling Emacs for Mac OS X (x86_64, i386, and PowerPC): > gcc -mmacosx-version-min=3D10.5 -std=3Dgnu99 -Wimplicit-function-decl= aration -Wold-style-definition -Wdeclaration-after-statement -DHAVE_CONF= IG_H -I. -I../src -I../lib -I/Users/david/src/emacs-dev/emacs-bzr/build-2= 011-11-28/lib-src -I/Users/david/src/emacs-dev/emacs-bzr/build-2011-11-28= /lib-src/../src -I/Users/david/src/emacs-dev/emacs-bzr/build-2011-11-28/l= ib-src/../lib -g -O2 /Users/david/src/emacs-dev/emacs-bzr/build-2011-1= 1-28/lib-src/emacsclient.c \ > -DVERSION=3D"\"24.0.91\"" \ > ../lib/libgnu.a -o emacsclient > /Users/david/src/emacs-dev/emacs-bzr/build-2011-11-28/lib-src/emacsclie= nt.c: In function 'set_local_socket': > /Users/david/src/emacs-dev/emacs-bzr/build-2011-11-28/lib-src/emacsclie= nt.c:1281: warning: passing argument 2 of 'confstr' discards qualifiers f= rom pointer target type > /Users/david/src/emacs-dev/emacs-bzr/build-2011-11-28/lib-src/emacsclie= nt.c: In function 'main': > /Users/david/src/emacs-dev/emacs-bzr/build-2011-11-28/lib-src/emacsclie= nt.c:1639: error: 'environ' undeclared (first use in this function) > /Users/david/src/emacs-dev/emacs-bzr/build-2011-11-28/lib-src/emacsclie= nt.c:1639: error: (Each undeclared identifier is reported only once > /Users/david/src/emacs-dev/emacs-bzr/build-2011-11-28/lib-src/emacsclie= nt.c:1639: error: for each function it appears in.) It appears to be caused by this checkin: > revno: 106533 > fixes bug(s): http://debbugs.gnu.org/9960 > committer: Eli Zaretskii > branch nick: trunk > timestamp: Sun 2011-11-27 20:52:53 +0200 > message: > Fix MS-Windows build with MSVC compiler. I'm guessing it's this hunk: =3D=3D=3D modified file 'lib-src/emacsclient.c' --- lib-src/emacsclient.c 2011-11-14 20:23:26 +0000 +++ lib-src/emacsclient.c 2011-11-27 18:52:53 +0000 @@ -1635,7 +1635,6 @@ /* Send over our environment and current directory. */ if (!current_frame) { - extern char **environ; int i; for (i =3D 0; environ[i]; i++) { Thanks, David --------------enig84A5328419A1DF51140B0234 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (Darwin) iQCVAwUBTtNVvKf81MBhyqGFAQiVNgP+OfRRfKaA/APn2nNLlom1Aqbx1sjk0glp iVjyt2e91AqdS9ZufjJ/keAzcO3eoZLJG/cSz77PmhvAsBcSQhltqOm17cvDEfkb bo6zjeAU/W5b1afseDXcHfD/dSS6QbVu1K6dZq0PMLE8bHTIbCDPJEjU/u8B2EtQ poGiBPkL1fU= =SYZb -----END PGP SIGNATURE----- --------------enig84A5328419A1DF51140B0234--