From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Killing a frame sometimes kills emacs Date: Thu, 17 Nov 2011 08:34:20 -0800 Organization: UCLA Computer Science Department Message-ID: <4EC5378C.5020500@cs.ucla.edu> References: <87d3flnxoo.fsf@thinkpad.tsdh.de> <83fwkhdld0.fsf@gnu.org> <871uw04lr9.fsf@thinkpad.tsdh.de> <87sjog35jj.fsf@thinkpad.tsdh.de> <4E5F7ECD.9060601@swipnet.se> <838vq8e0x5.fsf@gnu.org> <87sjn03tzx.fsf@thinkpad.tsdh.de> <87sjmzbmvv.fsf@thinkpad.tsdh.de> <87vcrvm0dr.fsf@stupidchicken.com> <87aa96ogb3.fsf@thinkpad.tsdh.de> <8762ijjbzu.fsf@tsdh.uni-koblenz.de> <878vnfngjk.fsf@gnu.org> <871ut6kgm8.fsf@tsdh.uni-koblenz.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1321547688 9389 80.91.229.12 (17 Nov 2011 16:34:48 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 17 Nov 2011 16:34:48 +0000 (UTC) Cc: emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 17 17:34:44 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RR4vE-0003f9-3I for ged-emacs-devel@m.gmane.org; Thu, 17 Nov 2011 17:34:44 +0100 Original-Received: from localhost ([::1]:58881 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RR4vD-0006AN-Lj for ged-emacs-devel@m.gmane.org; Thu, 17 Nov 2011 11:34:43 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:36852) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RR4vA-0006A5-66 for emacs-devel@gnu.org; Thu, 17 Nov 2011 11:34:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RR4v9-0003wb-0D for emacs-devel@gnu.org; Thu, 17 Nov 2011 11:34:40 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:41419) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RR4v8-0003vT-R8 for emacs-devel@gnu.org; Thu, 17 Nov 2011 11:34:38 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 79005A60002; Thu, 17 Nov 2011 08:34:21 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SLw3ajRmlQGd; Thu, 17 Nov 2011 08:34:20 -0800 (PST) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id C93EBA60001; Thu, 17 Nov 2011 08:34:20 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 In-Reply-To: <871ut6kgm8.fsf@tsdh.uni-koblenz.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:146079 Archived-At: On 11/17/11 05:45, Tassilo Horn wrote: > +#ifdef USE_GTK > + /* FIXME: Deleting the terminal crashes emacs because of a GTK > + bug. See the thread starting with > + <87d3flnxoo.fsf@thinkpad.tsdh.de> on emacs-devel. */ > + if (terminal->type != output_x_window) > +#endif /* USE_GTK */ > + terminal->reference_count--; Could you please use a URL rather than a Message-ID? The latter is hard for a random reader to follow. Perhaps the URL is what is meant? (Sorry, I can't easily tell.) Also, this code would be easier to read: if (! (use_gtk && terminal->type == output_x_window)) terminal->reference_count--; with something like this near the start of the file: #ifdef USE_GTK enum { use_gtk = 1 }; #else enum { use_gtk = 0 }; #endif