all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Your changes in revision 106240
Date: Sat, 29 Oct 2011 19:44:32 -0700	[thread overview]
Message-ID: <4EACBA10.9010007@cs.ucla.edu> (raw)
In-Reply-To: <83d3df8qod.fsf@gnu.org>

On 10/29/11 13:54, Eli Zaretskii wrote:
> what possible harm can be done by using an int here?

On a typical 64-bit host, using 'int' breaks a GDB command like
"xwhichsymbols Qnil 4294967297", by causing xwhichsymbols
to silently treat the 4294967297 as if it were 1.

For longstanding Emacs code this kind of fix is being put off
until after the release (see bug 9874) but newly-added
code like which_symbols should avoid arbitrary limits
unless there's a good reason to have them.



  reply	other threads:[~2011-10-30  2:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-29 20:54 Your changes in revision 106240 Eli Zaretskii
2011-10-30  2:44 ` Paul Eggert [this message]
2011-10-30  5:06   ` Stefan Monnier
2011-10-30  6:06     ` Paul Eggert
2011-10-30  6:28       ` Eli Zaretskii
2011-10-30  6:31       ` Stefan Monnier
2011-10-30  7:15         ` Paul Eggert
2011-10-30  7:27           ` Eli Zaretskii
2011-10-31  6:23             ` Paul Eggert
2011-10-30  8:07           ` Stefan Monnier
2011-10-31  6:28             ` Paul Eggert
2011-10-30  6:16     ` Eli Zaretskii
2011-10-30  7:04       ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EACBA10.9010007@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.