From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: Advising quit-window Date: Wed, 26 Oct 2011 11:21:49 +0200 Message-ID: <4EA7D12D.3000405@gmx.at> References: <8639eg8qm6.fsf@googlemail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1319620930 11338 80.91.229.12 (26 Oct 2011 09:22:10 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 26 Oct 2011 09:22:10 +0000 (UTC) Cc: emacs-devel@gnu.org To: Christoph Scholtes Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 26 11:22:05 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RIzgS-0008Nu-Jd for ged-emacs-devel@m.gmane.org; Wed, 26 Oct 2011 11:22:04 +0200 Original-Received: from localhost ([::1]:36405 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RIzgS-00074M-4d for ged-emacs-devel@m.gmane.org; Wed, 26 Oct 2011 05:22:04 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:56175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RIzgQ-00073a-0d for emacs-devel@gnu.org; Wed, 26 Oct 2011 05:22:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RIzgL-0005kM-Ur for emacs-devel@gnu.org; Wed, 26 Oct 2011 05:22:01 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.23]:52452) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1RIzgL-0005k6-B0 for emacs-devel@gnu.org; Wed, 26 Oct 2011 05:21:57 -0400 Original-Received: (qmail invoked by alias); 26 Oct 2011 09:21:53 -0000 Original-Received: from 62-47-39-90.adsl.highway.telekom.at (EHLO [62.47.39.90]) [62.47.39.90] by mail.gmx.net (mp015) with SMTP; 26 Oct 2011 11:21:53 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX184KnZBhAs4JuepKCq044A9HJQxZV8G5ZvIyiNOtG s798Q2W5ueys6s User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) In-Reply-To: <8639eg8qm6.fsf@googlemail.com> X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 213.165.64.23 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:145555 Archived-At: > `q' in a keymap. However, `quit-window' is also called internally, for > example by `quit-windows-on'. The latter is then called by vc mode to > kill the log buffer after a commit. It took me a while to figure out > that my advice actually caused the log buffer to be buried now, instead > of killed. IIRC `vc-mode' used to call `delete-windows-on' here which doesn't kill the argument buffer. The formulation "to be buried now" strikes me as if the buffer were killed before. Did you really observe such a change in behavior? martin