bug#9724: 24.0.90; ido-mode does not kill completions buffers

bug#9724: 24.0.90; ido-mode does not kill completions buffers

[Christoph Scholtes]

When ido-mode is enabled, completions buffers do not get killed when
aborting a completion with C-g. In case of ido-find-file, the *Ido
Completions* buffer seems to be buried, although cleared of any content
and in Fundamental mode. In case of another function, e.g. C-h k, the
*Completions* buffer seems to be buried instead of killed. When ido-mode
is disabled, the all completions buffers get killed.

emacs -Q 
M-: (ido-mode 1) 
C-x f 
Type t then <tab> 
C-g C-x b 
*Ido Completions* buffer is in buffer-list (but the buffer is strangely not
in Completions mode, but Fundamental mode).

C-h k
Type x then <tab>
C-g
C-x b
*Completions* buffer is in buffer-list 

I think on aborting completions with C-g both buffers should be killed
to bot pollute the buffer-list, like it does when ido-mode is not enabled.


In GNU Emacs 24.0.90.1 (i386-mingw-nt6.1.7601)
 of 2011-10-10 on MARVIN
Windowing system distributor `Microsoft Corp.', version 6.1.7601
configured using `configure --with-gcc (4.5) --no-opt --cflags -I"C:/Program Files (x86)/GnuWin32/include" -ID:/devel/emacs/libXpm-3.5.8/include -ID:/devel/emacs/libXpm-3.5.8/src -ID:/devel/emacs/gnutls-2.10.5-x86/include --ldflags -LD:/devel/emacs/gnutls-2.10.5-x86/lib'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENU
  value of $XMODIFIERS: nil
  locale-coding-system: cp1252
  default enable-multibyte-characters: t

Major mode: Emacs-Lisp

Minor modes in effect:
  paredit-mode: t
  my-keys-minor-mode: t
  erc-autojoin-mode: t
  erc-track-mode: t
  erc-match-mode: t
  erc-pcomplete-mode: t
  erc-stamp-mode: t
  recentf-mode: t
  desktop-save-mode: t
  autopair-mode: t
  autopair-global-mode: t
  yas/global-mode: t
  yas/minor-mode: t
  global-auto-revert-mode: t
  delete-selection-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  size-indication-mode: t
  column-number-mode: t
  line-number-mode: t

Recent input:
M-x r e p o r t - e <tab> <return>

Recent messages:
Loading c:/Users/Christoph/AppData/Roaming/.emacs.d/mail-config.el (source)...done
Loading c:/Users/Christoph/AppData/Roaming/.emacs.d/gnus-config.el (source)...done
Loading c:/Users/Christoph/AppData/Roaming/.emacs.d/erc-config.el (source)...done
Loading c:/Users/Christoph/AppData/Roaming/.emacs.d/org-config.el (source)...done
Loading c:/Users/Christoph/AppData/Roaming/.emacs.d/keybindings.el (source)...done
Loading c:/Users/Christoph/AppData/Roaming/.emacs.d/init-custom.el (source)...done
Loading vc-hg...done
Wrote c:/Users/Christoph/AppData/Roaming/.emacs.d/data/.emacs.desktop.lock
Desktop: 2 buffers restored.
For information about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:
None found.

Features:
(shadow sort gnus-cite mail-extr gnus-msg gnus-art mm-uu mml2015
epg-config mm-view mml-smime smime password-cache dig mailcap emacsbug
vc-hg paredit my-zenburn-theme erc-join erc-track erc-match
erc-pcomplete erc-stamp erc-goodies erc erc-backend erc-compat thingatpt
ispell bookmark+ bookmark+-key dired-x dired bookmark+-1 nnir gnus-sum
nnoo gnus-group gnus-undo nnmail mail-source gnus-start gnus-spec
gnus-int gnus-range message format-spec rfc822 mml mml-sec mm-decode
mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums
mailabbrev gmm-utils mailheader gnus-win gnus gnus-ems nnheader
gnus-util mail-utils mm-util mail-prsvr bookmark+-bmu help-mode view
bookmark+-lit pp+ bookmark+-mac bookmark pp recentf tree-widget wid-edit
midnight desktop ibuffer uniquify autopair google-c-style cc-styles
cc-align cc-engine cc-vars cc-defs browse-kill-ring+ browse-kill-ring
second-sel ido yasnippet dropdown-list derived edmacro kmacro assoc cl
org-habit org-agenda org byte-opt warnings bytecomp byte-compile cconv
macroexp ob-emacs-lisp ob-tangle ob-ref ob-lob ob-table org-footnote
org-src ob-comint ob-keys ob ob-eval org-pcomplete pcomplete comint ring
org-list org-faces org-compat org-entities org-macs noutline outline
easy-mmode regexp-opt cal-menu easymenu calendar cal-loaddefs
org-install server advice help-fns advice-preload debbugs-autoloads
package tabulated-list autorevert delsel time-date tooltip ediff-hook
vc-hooks lisp-float-type mwheel dos-w32 disp-table ls-lisp w32-win
w32-vars tool-bar dnd fontset image fringe lisp-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer button
faces cus-face files text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget hashtable-print-readable backquote
make-network-process multi-tty emacs)

bug#9724: 24.0.90; ido-mode does not kill completions buffers

[Christoph Scholtes]

On 10/10/2011 8:27 PM, I wrote:

> When ido-mode is enabled, completions buffers do not get killed when
> aborting a completion with C-g.

[...]

> When ido-mode is disabled, the all completions buffers get killed.

Actually, I was mistaken. The buffers do NOT get killed, when ido-mode 
is disabled.

So, maybe this behavior is intentional. Is there any way to have the 
completion buffers killed instead of buried?

However, it is strange that the *Ido Completions* buffer is empty and in 
Fundamental mode after pressing C-g.

Christoph

bug#9724: 24.0.90; ido-mode does not kill completions buffers

[Drew Adams]

> > When ido-mode is disabled, the all completions buffers get killed.
> 
> Actually, I was mistaken. The buffers do NOT get killed, when 
> ido-mode is disabled.
> 
> So, maybe this behavior is intentional. Is there any way to have the 
> completion buffers killed instead of buried?

Sounds like bug #9639...?

bug#9724: 24.0.90; ido-mode does not kill completions buffers

[Christoph Scholtes]

merge 9724 9639
quit

On 10/10/2011 10:55 PM, Drew Adams wrote:
>>> When ido-mode is disabled, the all completions buffers get killed.
>>
>> Actually, I was mistaken. The buffers do NOT get killed, when
>> ido-mode is disabled.
>>
>> So, maybe this behavior is intentional. Is there any way to have the
>> completion buffers killed instead of buried?
>
> Sounds like bug #9639...?

You are right. Thanks.

bug#9724: 24.0.90; ido-mode does not kill completions buffers

[martin rudalics]

 >>> So, maybe this behavior is intentional. Is there any way to have the
 >>> completion buffers killed instead of buried?
 >>
 >> Sounds like bug #9639...?
 >
 > You are right. Thanks.

The fix for bug#9639 doesn't change anything wrt whether the completion
buffer gets killed or buried.

martin

bug#9724: 24.0.90; ido-mode does not kill completions buffers

[Christoph Scholtes]

On 10/12/2011 12:52 AM, martin rudalics wrote:
>  >>> So, maybe this behavior is intentional. Is there any way to have the
>  >>> completion buffers killed instead of buried?
>  >>
>  >> Sounds like bug #9639...?
>  >
>  > You are right. Thanks.
>
> The fix for bug#9639 doesn't change anything wrt whether the completion
> buffer gets killed or buried.

Yes, I know. However the other discussion in that bug thread does sound 
relevant. I posted a question last night about a variable you said you 
had introduced, but I couldn't find it. I might not have cc'ed you on 
the message.

bug#9724: 24.0.90; ido-mode does not kill completions buffers

[martin rudalics]

 > Yes, I know. However the other discussion in that bug thread does sound
 > relevant. I posted a question last night about a variable you said you
 > had introduced, but I couldn't find it. I might not have cc'ed you on
 > the message.

I hope you found the variable in the meantime.

martin

bug#9724: 24.0.90; ido-mode does not kill completions buffers

[Christoph Scholtes]

On 10/12/2011 8:25 AM, martin rudalics wrote:
>  > Yes, I know. However the other discussion in that bug thread does sound
>  > relevant. I posted a question last night about a variable you said you
>  > had introduced, but I couldn't find it. I might not have cc'ed you on
>  > the message.
>
> I hope you found the variable in the meantime.

Yes, thanks.

However, setting the variable to delete-frame still does not kill the 
*Completions* buffer on aborting the completion attempt. Am I missing 
anything?

bug#9724: 24.0.90; ido-mode does not kill completions buffers

[martin rudalics]

 > However, setting the variable to delete-frame still does not kill the
 > *Completions* buffer on aborting the completion attempt. Am I missing
 > anything?

I tried to explain that when I wrote

 >>>> So, maybe this behavior is intentional. Is there any way to have the
 >>>> completion buffers killed instead of buried?
 >>>
 >>> Sounds like bug #9639...?
 >>
 >> You are right. Thanks.
 >
 > The fix for bug#9639 doesn't change anything wrt whether the completion
 > buffer gets killed or buried.

So let me try to explain this once more:

(1) Whether the buffer shall be killed or buried is decided by the
     function setting up the completion buffer.

(2) Whether the window showing the completion buffer is deleted or not
     is decided by (i) whether the buffer shall be killed or buried and,
     if the window appears on a standalone frame and the buffer shall be
     buried, (ii) the value of `frame-auto-hide-function'.

Bug#9724 is about (1) only.  Bug#9639 is about (2) only and not relevant
here.  Merging these two bugs was an incorrect decision.

martin