From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: Other details about completion. Date: Tue, 05 Apr 2022 00:33:02 +0200 Message-ID: <4E8D9AEF-4D7A-4B11-822F-8D0911964A05@aol.com> References: <20220401153839.idrzrbfl2yfzga3y.ref@Ergus> <20220401153839.idrzrbfl2yfzga3y@Ergus> <86r16g92v5.fsf@mail.linkov.net> <20220401202425.jfrwqmkm3ffmcm5h@Ergus> <20220404193501.adojhz7uvvaoq4sj@Ergus> <86czhw4oqr.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=----BVV9DUP0SMHXURK09DM5VYTZJWTFNM Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3946"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philip Kaludercic To: emacs-devel@gnu.org, Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 05 00:34:26 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbVHF-0000gI-18 for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Apr 2022 00:34:25 +0200 Original-Received: from localhost ([::1]:42256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nbVHD-0001rU-OQ for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Apr 2022 18:34:23 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37060) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbVG8-00018U-Dz for emacs-devel@gnu.org; Mon, 04 Apr 2022 18:33:19 -0400 Original-Received: from sonic311-14.consmr.mail.bf2.yahoo.com ([74.6.131.124]:43531) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nbVG5-0003rC-Qu for emacs-devel@gnu.org; Mon, 04 Apr 2022 18:33:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1649111592; bh=f/+HF0bIjdKVPwzFoH42X/iW5jofLUSLnq2oFfqYBao=; h=Date:From:To:CC:Subject:In-Reply-To:References:From:Subject:Reply-To; b=MxuWBeh8o0t2LDB+FPykf1maY1v+EAfaUjRaX9Qv/RHt79IIs+mtMuR8TBoLTSkFQkhduCB4biPANQHBbETQPsmPC9URZQ0R6wxkCW98br27tbxwrbqofYvQr0pa14VSvz7VKGw4/k7Exe5lykRlSL5qWzfPZajMJdeKN1vpwZhd7d/1LasUEyJpbMHTwudlV1EgWcjI+UzP85p/efDTANFk/gkyxdvLmuBZGxxiR4hBC8Iz20SH0MPUqcRsFuq6hcoE0mzAoeCnte5Y/3Lf/PGUTKQ1IcRVAaaSodZZ8/3xtwhH+mx7xbfVuINt0cx2O88WCgqRSRkHQqMaWCYLIg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1649111592; bh=A/1iFARWpA9k1BcN2PPOCGcqKrYJEiWszRzFEZMOPQh=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=ZyeafULw86lkKXAIMqxlkfR59SnDmyHX8mHNuJFx04FmZCP/H57TNkwFURZAMraVWrvn2GnvJMERrcSPVrIDt2v51hSZ41v03hUeYV1Kk1trzUfhvJsQqdGLLmjrZ8FVN6y+/vdgYkCwYhBZJFirZ78qLpUGL+LurHutoxqqA4UeqAVTIVSCqkVNUiur9zExF6hxsjzcxn+f1J9YpvXj5RddeEtyVxykLa1lPyhYosK0wTybXnxsAf14vzvQafdzvF1+JdqmJtv5kv0tBeQUXSwAfM/xqNWVzQRsDPTLX6wGiolJmdvC5sHDTsy8tsgxjED5kQsRgU9IuJLT6zxXyQ== X-YMail-OSG: 4XZiP0IVM1keldiSlZTMUdaMpLrC9obiq.SvaGzmvBQiQQnY3C4ZaMVFsI5pDY8 2NrzIUmufsbKYni1v1y0emqgnRYkdVCB5Dua9NAYxWH47vurjEnDzGOq33g11PuiwYi1_3ygO6DR fwon8ngkslc9q1Rl3p.T94595el4flgd..wFhRo6rtFEBBwt5N3a0U5bBgMIQ8JBh0144DMt0jVN 6aIe0O32uY9oZUZbZyL.g86W6y3u3IDssK.7kxWdb4sY2tcx7OcgBySfE2PAC9S8LPvbTbapgd7q 5d4gnYA2d73bEEPIOESsGe08s5gKGfaVDlEUpNIou4jpxw1t3MOr.d7.CmUbuRXIYjmNrvb1kzFD bGRRAd6Yif4BfuDmJ2JGtsomynFOAubDv0Ck302JyZYbA2loF059RYmNa9nlbq8tZV_jbMb0xFKp 7G4fWsaiG6B9NbBxRtrDBJ96K24YJUvbxNJqBkPozbb4fyrcG0M.GaXtdk7IGa4A3cmAL4eP56q9 kRQ8UiYU_1xfphYpBAsnO5w8A4S2FdtLuA0lCL91aetyh_ZgA0W__kjQ549SzC4CXluzKCDIiZnz VOgJfQvZINAGSUoVc0nurwKt2s9xOU9V1JmmibRv5Wp4QFxDYF2YUGToRTVKyLRbXbuGtWVQ12K3 rpNEon7oRxBCJdlM9XZiDkOSfLr9s3OegRUbI9Gf3GIQm6Q5bgB31Dme5ENfbnpv2MTYHOQG1lfs z25l63MKOvZ9Og_.Gel2L60cNAl3M.RRps2oGuKoFPU.pa8R92GTBZ4BlaO74vDOO1B1P_oEj0OD OyGWFHyfNnu1Vdc64IOK5TNXh_Le8_4vAhwBHpzWst X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.bf2.yahoo.com with HTTP; Mon, 4 Apr 2022 22:33:12 +0000 Original-Received: by hermes--canary-production-bf1-665cdb9985-tmblj (VZM Hermes SMTP Server) with ESMTPA ID 9a0771c8e47621f2ee622e2348f51630; Mon, 04 Apr 2022 22:33:07 +0000 (UTC) In-Reply-To: <86czhw4oqr.fsf@mail.linkov.net> X-Mailer: WebService/1.1.20001 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Received-SPF: pass client-ip=74.6.131.124; envelope-from=spacibba@aol.com; helo=sonic311-14.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287783 Archived-At: ------BVV9DUP0SMHXURK09DM5VYTZJWTFNM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable BTW Juri=2E Do you finally plan to add the mini-buffer navigate completions= features? On April 4, 2022 9:45:00 PM GMT+02:00, Juri Linkov wro= te: >> May I finally add this patch to master?? > >I don't know, maybe Philip has no time to review your patch? > >> On Fri, Apr 01, 2022 at 10:24:25PM +0200, Ergus wrote: >>>Hi again=2E=2E=2E >>> >>>Here I attached a small patch that makes 3 small changes: >>> >>>1) Remove the trailing newline in completions one-column >>>2) Use another condition in next-completion to jump to minibuffer=2E >>> >>>Normally next-completion with tabs at the end of the buffer needs an >>>extra tab because it goes to the end of the last completion before >>>jumping to the minibuffer or wrap=2E=2E That extra tab is because the >>>condition to jump or wrap was eobp/bobp assuming that there is not text >>>unproppertized after the last candidate=2E >>> >>>3) Remove a comment in switch-to-completions=2E That comment suggested = that >>>the next-completion action must be called inside >>>minibuffer-completion-help but IMO that is not totally correct when >>>completion-auto-select has some of the new values=2E >>> >>>Please, if anyone could review,correct and push I would be very >>>grateful=2E > --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E ------BVV9DUP0SMHXURK09DM5VYTZJWTFNM Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable BTW Juri=2E Do you finally plan to add the mini-bu= ffer navigate completions features?

On Ap= ril 4, 2022 9:45:00 PM GMT+02:00, Juri Linkov <juri@linkov=2Enet> wro= te:
May I finally add this patch to master??

I do=
n't know, maybe Philip has no time to review your patch?

On Fri, Apr 01, 2022 at 10:24:25PM +0=
200, Ergus wrote:
Hi ag=
ain=2E=2E=2E

Here I attached a small patch that makes 3 small change=
s:

1) Remove the trailing newline in completions one-column
2) Us=
e another condition in next-completion to jump to minibuffer=2E

Norm=
ally next-completion with tabs at the end of the buffer needs an
extra t=
ab because it goes to the end of the last completion before
jumping to t=
he minibuffer or wrap=2E=2E That extra tab is because the
condition to j=
ump or wrap was eobp/bobp assuming that there is not text
unproppertized=
 after the last candidate=2E

3) Remove a comment in switch-to-comple=
tions=2E That comment suggested that
the next-completion action must be =
called inside
minibuffer-completion-help but IMO that is not totally cor=
rect when
completion-auto-select has some of the new values=2E

Pl=
ease, if anyone could review,correct and push I would be very
grateful=
=2E

--
Sent from my= Android device with K-9 Mail=2E Please excuse my brevity=2E
------BVV9DUP0SMHXURK09DM5VYTZJWTFNM--