From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Jan D." Newsgroups: gmane.emacs.bugs Subject: bug#3225: session manager hang due to block on ice_fd (failure to check for EINTR in select) Date: Thu, 06 Oct 2011 08:08:27 +0200 Message-ID: <4E8D45DB.4070102@swipnet.se> References: <87prenqn7i.fsf@karlt.net> <87wrcjvvsi.fsf@karlt.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1317881345 1403 80.91.229.12 (6 Oct 2011 06:09:05 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 6 Oct 2011 06:09:05 +0000 (UTC) Cc: Karl Tomlinson , 3225@debbugs.gnu.org To: Karl Tomlinson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 06 08:09:00 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RBh8e-0005RW-1o for geb-bug-gnu-emacs@m.gmane.org; Thu, 06 Oct 2011 08:09:00 +0200 Original-Received: from localhost ([::1]:48422 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RBh8c-0003Zj-Od for geb-bug-gnu-emacs@m.gmane.org; Thu, 06 Oct 2011 02:08:58 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:47591) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RBh8a-0003Zc-0U for bug-gnu-emacs@gnu.org; Thu, 06 Oct 2011 02:08:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RBh8Y-0006nb-Tk for bug-gnu-emacs@gnu.org; Thu, 06 Oct 2011 02:08:55 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59107) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RBh8Y-0006nV-R2 for bug-gnu-emacs@gnu.org; Thu, 06 Oct 2011 02:08:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RBh8f-0008SE-LY for bug-gnu-emacs@gnu.org; Thu, 06 Oct 2011 02:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Jan D." Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Oct 2011 06:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 3225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 3225-submit@debbugs.gnu.org id=B3225.131788132532475 (code B ref 3225); Thu, 06 Oct 2011 06:09:01 +0000 Original-Received: (at 3225) by debbugs.gnu.org; 6 Oct 2011 06:08:45 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RBh8P-0008Rk-5w for submit@debbugs.gnu.org; Thu, 06 Oct 2011 02:08:45 -0400 Original-Received: from smtprelay-b12.telenor.se ([62.127.194.21]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RBh8N-0008RY-Es for 3225@debbugs.gnu.org; Thu, 06 Oct 2011 02:08:44 -0400 Original-Received: from iph3.telenor.se (iph3.telenor.se [195.54.127.134]) by smtprelay-b12.telenor.se (Postfix) with ESMTP id 69404C26C for <3225@debbugs.gnu.org>; Thu, 6 Oct 2011 08:08:30 +0200 (CEST) X-SENDER-IP: [85.225.45.201] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgA+AENFjU5V4S3JPGdsb2JhbABEqCYZAQEBATcygVMBAQU4Dw8iARALGAkWDwkDAgECARsMChQGDQEHAQGHewSoQo1khykEmRWDNohp X-IronPort-AV: E=Sophos;i="4.68,495,1312149600"; d="scan'208";a="125717055" Original-Received: from c-c92de155.25-1-64736c10.cust.bredbandsbolaget.se (HELO coolsville.localdomain) ([85.225.45.201]) by iph3.telenor.se with ESMTP; 06 Oct 2011 08:08:30 +0200 Original-Received: from [10.225.16.4] (unknown [193.45.43.33]) by coolsville.localdomain (Postfix) with ESMTPSA id 1F2667FA058; Thu, 6 Oct 2011 08:08:29 +0200 (CEST) User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 In-Reply-To: <87wrcjvvsi.fsf@karlt.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 06 Oct 2011 02:09:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:52256 Archived-At: Karl Tomlinson skrev 2011-10-06 01:54: > Glenn Morris writes: > >> Karl Tomlinson wrote: >> >>> x_session_check_input in xmsfns.c has this code: >>> >>> if (select (ice_fd+1,&read_fds, >>> (SELECT_TYPE *)0, (SELECT_TYPE *)0,&tmout)< 0) >>> { >>> ice_fd = -1; >>> return 0; >>> } >>> >>> So ice_fd is set to -1 when select returns due to a signal >>> (with errno == EINTR). This leaves the fd open but prevents >>> further processing. >> >> Sorry for the delay. Is this still an issue? The current code does not >> look like that. > > I haven't tested, but it looks like this should be fixed by > http://bzr.savannah.gnu.org/lh/emacs/trunk/revision/103065 > It should be. The select call in process.c is now used and it handles EINTR properly. Jan D.