From: "Jan D." <jan.h.d@swipnet.se>
To: Karl Tomlinson <karlt@karlt.net>
Cc: Karl Tomlinson <bugs+emacs@karlt.net>, 3225@debbugs.gnu.org
Subject: bug#3225: session manager hang due to block on ice_fd (failure to check for EINTR in select)
Date: Thu, 06 Oct 2011 08:08:27 +0200 [thread overview]
Message-ID: <4E8D45DB.4070102@swipnet.se> (raw)
In-Reply-To: <87wrcjvvsi.fsf@karlt.net>
Karl Tomlinson skrev 2011-10-06 01:54:
> Glenn Morris writes:
>
>> Karl Tomlinson wrote:
>>
>>> x_session_check_input in xmsfns.c has this code:
>>>
>>> if (select (ice_fd+1,&read_fds,
>>> (SELECT_TYPE *)0, (SELECT_TYPE *)0,&tmout)< 0)
>>> {
>>> ice_fd = -1;
>>> return 0;
>>> }
>>>
>>> So ice_fd is set to -1 when select returns due to a signal
>>> (with errno == EINTR). This leaves the fd open but prevents
>>> further processing.
>>
>> Sorry for the delay. Is this still an issue? The current code does not
>> look like that.
>
> I haven't tested, but it looks like this should be fixed by
> http://bzr.savannah.gnu.org/lh/emacs/trunk/revision/103065
>
It should be. The select call in process.c is now used and it handles
EINTR properly.
Jan D.
prev parent reply other threads:[~2011-10-06 6:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-05 21:00 bug#3225: session manager hang due to block on ice_fd (failure to check for EINTR in select) Karl Tomlinson
2011-10-05 19:02 ` Glenn Morris
2011-10-05 23:54 ` Karl Tomlinson
2011-10-06 6:08 ` Jan D. [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8D45DB.4070102@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=3225@debbugs.gnu.org \
--cc=bugs+emacs@karlt.net \
--cc=karlt@karlt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.