Re: Reminder about feature freeze

[Deniz Dogan <deniz@dogan.se>]

[-- Attachment #1: Type: text/plain, Size: 839 bytes --]

On 2011-06-28 17:12, Chong Yidong wrote:
> Just a reminder: the pretest is scheduled for late July, as discussed at
> http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00953.html.
>
> In order to ensure a smooth transition to the pretest, I encourage
> everyone who has a pending patch that implements a new feature to commit
> it, or ask to have it committed, ASAP.  If committing during July,
> please discuss on emacs-devel first.
>
> If you're aware of any languishing patch that ought to be included in
> Emacs 24, please point it out.  Thanks.
>

So as I understand it we are now in the feature freeze.  I have a minor 
addition (feature) for rcirc that I'd like to push.  It adds the option 
to fill according to window width or a user's custom function.  See the 
attachment.

Is it okay to push this to trunk?

Deniz Dogan

[-- Attachment #2: rcirc-window-width.patch --]
[-- Type: text/plain, Size: 1306 bytes --]

=== modified file 'lisp/net/rcirc.el'
--- lisp/net/rcirc.el	2011-08-04 00:58:07 +0000
+++ lisp/net/rcirc.el	2011-08-17 13:43:29 +0000
@@ -149,7 +149,9 @@
 maximum frame width."
   :type '(choice (const :tag "Value of `fill-column'")
 		 (const :tag "Full frame width" frame-width)
-		 (integer :tag "Number of columns"))
+		 (const :tag "Full window width" window-width)
+		 (integer :tag "Number of columns")
+		 (function :tag "Return value of function" function))
   :group 'rcirc)
 
 (defcustom rcirc-fill-prefix nil
@@ -2421,13 +2423,16 @@
     (let ((fill-prefix
 	   (or rcirc-fill-prefix
 	       (make-string (- (point) (line-beginning-position)) ?\s)))
-	  (fill-column (- (cond ((eq rcirc-fill-column 'frame-width)
-				 (1- (frame-width)))
-				(rcirc-fill-column
-				 rcirc-fill-column)
-				(t fill-column))
-			  ;; make sure ... doesn't cause line wrapping
-			  3)))
+	  (fill-column
+	   (cond ((eq rcirc-fill-column 'frame-width)
+		  (1- (frame-width)))
+		 ((eq rcirc-fill-column 'window-width)
+		  (1- (window-width)))
+		 ((fboundp rcirc-fill-column) ; custom function
+		  (funcall rcirc-fill-column sender response))
+		 (rcirc-fill-column    	; fix integer value
+		  rcirc-fill-column)
+		 (t fill-column))))
       (fill-region (point) (point-max) nil t))))
 \f
 ;;; handlers