From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] system-type cygwin with window-system w32 Date: Mon, 18 Jul 2011 09:13:36 -0700 Organization: UCLA Computer Science Department Message-ID: <4E245BB0.3000403@cs.ucla.edu> References: <4E2377E2.1020804@gmail.com> <4E23D2BF.7080309@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1311007023 15509 80.91.229.12 (18 Jul 2011 16:37:03 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 18 Jul 2011 16:37:03 +0000 (UTC) Cc: emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 18 18:36:55 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QiqoR-0000pM-9Z for ged-emacs-devel@m.gmane.org; Mon, 18 Jul 2011 18:36:55 +0200 Original-Received: from localhost ([::1]:58922 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QiqoP-0000zD-Ue for ged-emacs-devel@m.gmane.org; Mon, 18 Jul 2011 12:36:54 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:59763) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QiqRy-0002jT-4a for emacs-devel@gnu.org; Mon, 18 Jul 2011 12:13:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QiqRw-0005fS-B8 for emacs-devel@gnu.org; Mon, 18 Jul 2011 12:13:41 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:50532) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QiqRv-0005fK-OH for emacs-devel@gnu.org; Mon, 18 Jul 2011 12:13:40 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 4FFA839E80F0; Mon, 18 Jul 2011 09:13:37 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TPbGkTJzU+YB; Mon, 18 Jul 2011 09:13:37 -0700 (PDT) Original-Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id EF4BE39E80E0; Mon, 18 Jul 2011 09:13:36 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc14 Thunderbird/3.1.11 In-Reply-To: <4E23D2BF.7080309@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:142114 Archived-At: I have qualms about this part of the patch, in lisp.h: +#define t(...) \ + ({ \ + fprintf (stderr, "T:%s:%u: ", \ + __FUNCTION__, __LINE__); \ + fprintf (stderr, __VA_ARGS__); \ + fputc ('\n', stderr); \ + }) + Is this some sort of test scaffolding that is intended to be removed before the patch actually goes in? If not, it has some problems. The name "t" is too short and cryptic. The ({...}} construction is not standard C and won't work with many non-GCC compilers. The __FUNCTION__ macro is also GCC-specific.