From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] system-type cygwin with window-system w32 Date: Mon, 18 Jul 2011 03:10:11 -0700 Message-ID: <4E240683.3030604@gmail.com> References: <4E2377E2.1020804@gmail.com> <4E23D2BF.7080309@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigDEFA5FA97E6735756D98ECFB" X-Trace: dough.gmane.org 1310984087 30638 80.91.229.12 (18 Jul 2011 10:14:47 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 18 Jul 2011 10:14:47 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 18 12:14:40 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QikqT-0003HM-J7 for ged-emacs-devel@m.gmane.org; Mon, 18 Jul 2011 12:14:37 +0200 Original-Received: from localhost ([::1]:56399 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QikqS-0006Yz-7Z for ged-emacs-devel@m.gmane.org; Mon, 18 Jul 2011 06:14:36 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:36521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QikmP-0005ha-9N for emacs-devel@gnu.org; Mon, 18 Jul 2011 06:10:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QikmN-0002zk-Li for emacs-devel@gnu.org; Mon, 18 Jul 2011 06:10:24 -0400 Original-Received: from mail-iy0-f169.google.com ([209.85.210.169]:35688) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QikmK-0002zC-0D; Mon, 18 Jul 2011 06:10:20 -0400 Original-Received: by iyb14 with SMTP id 14so1915123iyb.0 for ; Mon, 18 Jul 2011 03:10:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type; bh=gEINfmg3yek7qxjS2eN0GjT8Ib6Q8ZGVbvP7OB2HIj4=; b=IFmI++w6vsgwIeHO7eoAZ59At92P5lASAmymJJanK8YVcUbf8E2xG86b9p6CU23nvR TE0OqS2dAChnoalpVNg6239YIrveYXICA+Rjg8Kr7mQV83pMGyYTUOEk6RAoIjbxZAcb qhcxTZSSbdAhie9hT05nfZ12YPej9wcxmGlNU= Original-Received: by 10.42.144.195 with SMTP id c3mr7318887icv.9.1310983818597; Mon, 18 Jul 2011 03:10:18 -0700 (PDT) Original-Received: from [192.168.1.2] (c-24-18-179-193.hsd1.wa.comcast.net [24.18.179.193]) by mx.google.com with ESMTPS id f14sm2886477icm.3.2011.07.18.03.10.17 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 18 Jul 2011 03:10:18 -0700 (PDT) User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:5.0) Gecko/20110624 Thunderbird/5.0 In-Reply-To: X-Enigmail-Version: 1.2 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.210.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:142097 Archived-At: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigDEFA5FA97E6735756D98ECFB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 7/18/11 1:53 AM, Eli Zaretskii wrote: >> S_ISCTG and such aren't being defined under Cygwin, causing compilatio= n >> errors. There's probably a better way to deal with the underlying pro= blem. >=20 > Yes, the files in lib/sys_stat.in.h is supposed to do that already. > I'm curious why it didn't work for you. I didn't look into why it didn't work. I can do some investigation, but I'm not very familiar with how gnulib stuff actually works. > I'd prefer a separate file common to w2 and Cygwin-on-w32, if that's > needed. w32fns.c tries to be as similar to xfns.c as possible, so > putting there stuff that's not relevant would be a disadvantage. Fair enough. I'll move some code around; would you object to having w32.c, cygw32.c, and ntw32.c and corresponding headers? >>>> +#define t(...) \ >>>> + ({ \ >>>> + fprintf (stderr, "T:%s:%u: ", \ >>>> + __FUNCTION__, __LINE__); \ >>>> + fprintf (stderr, __VA_ARGS__); \ >>>> + fputc ('\n', stderr); \ >>>> + }) >>>> + >>> >>> What is this stuff about? >> >> Debug scaffolding --- in this case, generally useful, I think, at leas= t >> as a replacement for the numerous bespoke tracing macros scattered >> everywhere in the code. >=20 > Fine, but (a) please see if there's no macro already available that > can be used instead;=20 I didn't see anything suitable. and (b) let's have this a separate changeset. Fair enough, though I'll keep it in the patch for now just to make debugging easier. (gdb under Cygwin is problematic at best, IME.) >>> This is based on reviewing only a part of the patch, I will have more= >>> later. The patch is very large and complicated, and the lack of a >>> ChangeLog that describes the changes, particularly those which move >>> code between different files, does not help... >> >> Of course. It's a work in progress --- a first stab, really. Once I >> clean up the code a bit, I'll put it into a form that's easier to cons= ume. >=20 > My point was that there are several issues here that need to be > discussed before you invest too much energy into them. So please > consider starting these discussion sooner rather than later, and the > additional information I didn't find in the ChangeLog would be > instrumental at that time. Sure, but there's also something to be said for building a prototype as well. --------------enigDEFA5FA97E6735756D98ECFB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (Darwin) iEYEARECAAYFAk4kBogACgkQ17c2LVA10VuB2QCgmRn8guLr7j85iy47UekLbKtz 8uoAoICEUakuN5XKtZPpQq3B2oW/wiO6 =2urJ -----END PGP SIGNATURE----- --------------enigDEFA5FA97E6735756D98ECFB--