From: Daniel Colascione <dan.colascione@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] system-type cygwin with window-system w32
Date: Mon, 18 Jul 2011 03:10:11 -0700 [thread overview]
Message-ID: <4E240683.3030604@gmail.com> (raw)
In-Reply-To: <E1QijZc-0004xp-Ho@fencepost.gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2567 bytes --]
On 7/18/11 1:53 AM, Eli Zaretskii wrote:
>> S_ISCTG and such aren't being defined under Cygwin, causing compilation
>> errors. There's probably a better way to deal with the underlying problem.
>
> Yes, the files in lib/sys_stat.in.h is supposed to do that already.
> I'm curious why it didn't work for you.
I didn't look into why it didn't work. I can do some investigation, but
I'm not very familiar with how gnulib stuff actually works.
> I'd prefer a separate file common to w2 and Cygwin-on-w32, if that's
> needed. w32fns.c tries to be as similar to xfns.c as possible, so
> putting there stuff that's not relevant would be a disadvantage.
Fair enough. I'll move some code around; would you object to having
w32.c, cygw32.c, and ntw32.c and corresponding headers?
>>>> +#define t(...) \
>>>> + ({ \
>>>> + fprintf (stderr, "T:%s:%u: ", \
>>>> + __FUNCTION__, __LINE__); \
>>>> + fprintf (stderr, __VA_ARGS__); \
>>>> + fputc ('\n', stderr); \
>>>> + })
>>>> +
>>>
>>> What is this stuff about?
>>
>> Debug scaffolding --- in this case, generally useful, I think, at least
>> as a replacement for the numerous bespoke tracing macros scattered
>> everywhere in the code.
>
> Fine, but (a) please see if there's no macro already available that
> can be used instead;
I didn't see anything suitable.
and (b) let's have this a separate changeset.
Fair enough, though I'll keep it in the patch for now just to make
debugging easier. (gdb under Cygwin is problematic at best, IME.)
>>> This is based on reviewing only a part of the patch, I will have more
>>> later. The patch is very large and complicated, and the lack of a
>>> ChangeLog that describes the changes, particularly those which move
>>> code between different files, does not help...
>>
>> Of course. It's a work in progress --- a first stab, really. Once I
>> clean up the code a bit, I'll put it into a form that's easier to consume.
>
> My point was that there are several issues here that need to be
> discussed before you invest too much energy into them. So please
> consider starting these discussion sooner rather than later, and the
> additional information I didn't find in the ChangeLog would be
> instrumental at that time.
Sure, but there's also something to be said for building a prototype as
well.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2011-07-18 10:10 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 0:01 [PATCH] system-type cygwin with window-system w32 Daniel Colascione
2011-07-18 0:06 ` Daniel Colascione
2011-07-18 6:13 ` Eli Zaretskii
2011-07-18 6:29 ` Daniel Colascione
2011-07-18 8:53 ` Eli Zaretskii
2011-07-18 10:10 ` Daniel Colascione [this message]
2011-07-18 16:04 ` Paul Eggert
2011-07-18 16:19 ` Eli Zaretskii
2011-07-18 13:55 ` Jason Rumney
2011-07-18 16:13 ` Paul Eggert
2011-07-18 17:34 ` Andreas Schwab
2011-07-18 6:53 ` Eli Zaretskii
2011-07-18 7:01 ` Daniel Colascione
2011-07-18 9:04 ` Eli Zaretskii
2011-07-18 9:41 ` Daniel Colascione
2011-07-18 10:10 ` Eli Zaretskii
2011-07-18 10:49 ` Daniel Colascione
2011-07-18 11:22 ` Juanma Barranquero
2011-07-18 16:41 ` Eli Zaretskii
2011-07-18 16:48 ` Daniel Colascione
2011-07-18 17:08 ` Eli Zaretskii
2011-07-18 22:08 ` Richard Stallman
2011-07-18 22:24 ` Daniel Colascione
2011-07-18 22:45 ` David Kastrup
2011-07-18 22:56 ` Daniel Colascione
2011-07-19 16:49 ` Richard Stallman
2011-07-21 1:44 ` Lennart Borgman
2011-07-18 22:08 ` Richard Stallman
2011-07-18 13:31 ` Jason Rumney
2011-07-18 13:46 ` Richard Riley
2011-07-18 8:42 ` Eli Zaretskii
2011-07-18 10:33 ` Daniel Colascione
2011-07-18 16:29 ` Eli Zaretskii
2011-07-18 17:04 ` Daniel Colascione
2011-07-18 15:54 ` Stefan Monnier
2011-07-18 15:55 ` Stefan Monnier
2011-07-18 17:37 ` Andreas Schwab
-- strict thread matches above, loose matches on Subject: below --
2011-07-18 17:33 grischka
2011-07-18 17:50 ` Daniel Colascione
2011-07-18 18:08 ` Daniel Colascione
2011-07-18 18:52 ` grischka
2011-07-18 19:11 ` Daniel Colascione
2011-07-18 21:01 ` grischka
2011-07-19 2:58 ` Eli Zaretskii
2011-07-19 2:59 ` Daniel Colascione
2011-07-21 17:44 ` Lennart Borgman
2011-07-22 7:30 ` Daniel Colascione
2011-07-22 7:41 ` Lennart Borgman
2011-07-22 21:24 ` chad
2011-07-22 21:57 ` Lennart Borgman
2011-07-18 18:38 ` grischka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E240683.3030604@gmail.com \
--to=dan.colascione@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.