From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 9010@debbugs.gnu.org
Subject: bug#9010: sigprocmask -> pthread_sigmask for Emacs
Date: Fri, 08 Jul 2011 02:58:55 -0700 [thread overview]
Message-ID: <4E16D4DF.5060307@cs.ucla.edu> (raw)
In-Reply-To: <83pqllnsv7.fsf@gnu.org>
On 07/08/11 00:17, Eli Zaretskii wrote:
> After your patch, will there be any code in Emacs that still uses
> sigprocmask? If not, we could just rename the w32.c sigprocmask stub
> to pthread_sigmask. If sigprocmask will still be used, then your
> suggestion for pthread_sigmask to call sigprocmask is TRT.
There will still be some code in lib-src/emacsclient.c that uses sigprocmask,
because emacsclient is single-threaded and does not need pthread_sigmask.
pthread_sigmask sometimes needs extra libraries, such as -lpthread;
these libraries are ordinarily linked into Emacs anyway, so it's no
big deal for Emacs to call pthread_sigmask, but I'd rather not have
single-threaded apps link to -lpthread if they don't need it.
Does emacsclient run on w32 and/or msdos? If so, those libraries
will need both pthread_sigmask and sigprocmask. If not, they can
simply drop sigprocmask.
I should mention that pthread_sigmask's API differs from that of sigprocmask
in one minor way: if there is an error, sigprocmask sets errno whereas pthread_sigmask
returns the error number. Emacs doesn't care about the difference, as it
never looks at the error number, so the Windows libraries needn't worry
about this detail.
next prev parent reply other threads:[~2011-07-08 9:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-06 18:11 bug#9010: sigprocmask -> pthread_sigmask for Emacs Paul Eggert
2011-07-07 8:01 ` Jan Djärv
2011-07-08 7:17 ` Eli Zaretskii
2011-07-08 9:58 ` Paul Eggert [this message]
2011-07-08 10:16 ` Eli Zaretskii
2011-07-08 20:42 ` Paul Eggert
2011-07-08 23:29 ` Juanma Barranquero
2011-07-08 23:32 ` Paul Eggert
2011-07-09 0:13 ` Juanma Barranquero
2011-07-09 7:02 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E16D4DF.5060307@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=9010@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.