From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [PATCH updated] Support for filesystem watching (inotify) Date: Wed, 06 Jul 2011 08:54:28 -0700 Organization: UCLA Computer Science Department Message-ID: <4E148534.40106@cs.ucla.edu> References: <201106040034.15598.ruediger@c-plusplus.de> <201106061825.25078.ruediger@c-plusplus.de> <201106240250.01247.ruediger@c-plusplus.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1309968602 2130 80.91.229.12 (6 Jul 2011 16:10:02 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 6 Jul 2011 16:10:02 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 06 18:09:57 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QeUfl-0008Fy-8A for ged-emacs-devel@m.gmane.org; Wed, 06 Jul 2011 18:09:57 +0200 Original-Received: from localhost ([::1]:36376 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QeUfj-0006dh-Fx for ged-emacs-devel@m.gmane.org; Wed, 06 Jul 2011 12:09:55 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:38970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QeUQw-0002zp-7i for emacs-devel@gnu.org; Wed, 06 Jul 2011 11:54:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QeUQu-000115-Kx for emacs-devel@gnu.org; Wed, 06 Jul 2011 11:54:37 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:57797) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QeUQu-00010i-1i for emacs-devel@gnu.org; Wed, 06 Jul 2011 11:54:36 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 7FDAF39E80FA; Wed, 6 Jul 2011 08:54:33 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T1x4-5YB1GeD; Wed, 6 Jul 2011 08:54:33 -0700 (PDT) Original-Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 165AE39E80F8; Wed, 6 Jul 2011 08:54:33 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Thunderbird/3.1.10 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:141660 Archived-At: On 07/06/11 06:36, Stefan Monnier wrote: > My preference would be to wait for 24.2 since we're in feature freeze, > but it's the kind of feature which benefits from being available early > so other packages can start using it. WDYT? I briefly looked at it for integer-overflow issues, and found one: it assumes that inotify cookies fit into an Emacs fixnum. This assumption isn't true on 32-bit hosts, unless Emacs is configured with --with-wide-int. As you know I'm a fan of wide integers, and my preferred solution would be to make --with-wide-int the default, which would solve the problem. As that is also being considered for 24.2, perhaps the inotify feature should wait for 24.2 as well.