From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#71760: [PATCH] js-ts-mode: Fix filling of jsdoc blocks Date: Sat, 3 Aug 2024 00:34:24 -0700 Message-ID: <4E0726C0-DF68-46FE-943E-2D242959BD32@gmail.com> References: <875xsoousd.fsf@cassou.me> <87sevqx90w.fsf@cassou.me> <94fbe0b9-004b-49ea-9a22-de1e4f1d6f68@gutov.dev> <965418E3-4D87-4F83-8CFD-4BDDDE749BBF@gmail.com> <9a1f6d7c-b7e6-4da4-845c-c9dee5baa8c1@gutov.dev> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33093"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Damien Cassou , 71760@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 03 09:37:05 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sa9K4-0008QF-Uy for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Aug 2024 09:37:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sa9Jl-0001Ae-MN; Sat, 03 Aug 2024 03:36:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sa9Jk-0001AN-Ku for bug-gnu-emacs@gnu.org; Sat, 03 Aug 2024 03:36:44 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sa9Jk-0008Si-B1 for bug-gnu-emacs@gnu.org; Sat, 03 Aug 2024 03:36:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:Date:In-Reply-To:From:Mime-Version:To:Subject; bh=RO8X5EAUs2/c9WkhWsewYyVlMwL07yIO0/Zm4FK4HSE=; b=F96Kjio9izLK+r98X360Ktswd4kVl0qsQRXpnUg93B2Ycx49kufBMZT+e636Mp6vnIC0P1Ac95g/Wvcs5VoTLrggRkm/wfvb8lH/NFXnnJehU2QIDvr2eEZGm5mBd770bGCX+NU2Ci1iVXhLDhxNk3s29BzVayckJC2hJSNBeV38i7AUbTTctG7VyKOTADpXkkzxsm+feq8YYs+oeDf3dZWMp9XE4Ke3EGXnm8KMBX82E5ZM1ZAhXYMSP8r5R9R9wTNNcKSJOVBKBwcOz06RDptScV9FzOQsL7kFSDxC/Jt007VISimaLW9R+Raf6iCnC8cym6DdM8vNw3EB/UlsPw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sa9K2-0004Iq-KW for bug-gnu-emacs@gnu.org; Sat, 03 Aug 2024 03:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Aug 2024 07:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71760 X-GNU-PR-Package: emacs Original-Received: via spool by 71760-submit@debbugs.gnu.org id=B71760.172267056516478 (code B ref 71760); Sat, 03 Aug 2024 07:37:02 +0000 Original-Received: (at 71760) by debbugs.gnu.org; 3 Aug 2024 07:36:05 +0000 Original-Received: from localhost ([127.0.0.1]:54023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sa9J6-0004Hh-8n for submit@debbugs.gnu.org; Sat, 03 Aug 2024 03:36:05 -0400 Original-Received: from mail-oa1-f53.google.com ([209.85.160.53]:57506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sa9J3-0004HC-Fx for 71760@debbugs.gnu.org; Sat, 03 Aug 2024 03:36:03 -0400 Original-Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-2642cfb2f6aso5704875fac.2 for <71760@debbugs.gnu.org>; Sat, 03 Aug 2024 00:35:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722670476; x=1723275276; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RO8X5EAUs2/c9WkhWsewYyVlMwL07yIO0/Zm4FK4HSE=; b=A5b+lZljXIU98ayfsZZ52Nq69F5786EJyknXnJzHy47VsRJGA75qXRBvkJ/mlIS5GB /dsCJ1iYa2XYZmN1M2th8vOUPysdL0bSe1vtksO2YdPsLWx0duxQPLHFpRr/yGOkZD+3 TtUypUks7EhZGFaxL+roFr+g7SQC/knk9IqPEVU+PuI4agJHm9SS+GBhoSPTniUM20E5 fUkhNdE5ok2hH/0SMvdNR48rsdlgQh2f01UV0dk5aF6nuaMliI0VIvJ1SkVKwNf1E58y xXP9UTSab2JKcQS6jjgfL+aOpF3gjAI/1XwFF1GACVFr3Rwb6bCFL8Mi5jdVTpH+bZOR rp0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722670476; x=1723275276; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RO8X5EAUs2/c9WkhWsewYyVlMwL07yIO0/Zm4FK4HSE=; b=UJ7NV/F8jZC55PgZ5bHVVKHUzxIGpOgEAaGGeGdSDRfIezJPH5zg6LeWtYzhxQLHEe JR1fL4mGPPicZOqeJfPn++MMozQ7Oy1kKPQ9yM0IGzLq8IqpZW9dlj2zGT3GtXN28rCV qLji9myF03vj6C2Id7Fjn6HlCH1khkZtCcfkvZ03YDi5fWM/FUuyHhCHYhVScju9xhMV oLCo2mGM12aAfEiuASgHU5GI9jbikAD00AzNo5Uyix6Hdk6+/r2YbmIAW/YiIFLlqI6X aYndCUpzPpDXfNWEwS6pBpDmaJXQ+0Rdl78qEPzmyQbDWPP0GjNvYdNQeScb4ENTfkVE sGdA== X-Forwarded-Encrypted: i=1; AJvYcCVJjC+7nmQI5dNYPPhIVxQicemFUpUkDhh/bpkqjCn2zxmWnDZuPAE801s943SG7CIBcwksyxqlvKH7gjrwoOsdGx+Kjg4= X-Gm-Message-State: AOJu0YwbsCvDc4rHBcquaeQP9aaaieCA/3LXCWaQaXFuz4DmdGLZaaZ1 VsY6EuSORcBH9V1kx28im8STyOC8aAlKAHuIGMXbPIg97SUaIE2q X-Google-Smtp-Source: AGHT+IGrEy30HAusXW3rpqYMi49nCLofMfQ8S0wJpuMpEqZiWtTkj0y51nruj7rOruQtB56i/cjtow== X-Received: by 2002:a05:6870:65a0:b0:261:211:9d0d with SMTP id 586e51a60fabf-26891e89dffmr6501224fac.40.1722670476092; Sat, 03 Aug 2024 00:34:36 -0700 (PDT) Original-Received: from smtpclient.apple ([2601:646:8f81:6120:fc55:48f9:5161:d744]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7106ec5c929sm2304419b3a.88.2024.08.03.00.34.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Aug 2024 00:34:35 -0700 (PDT) In-Reply-To: <9a1f6d7c-b7e6-4da4-845c-c9dee5baa8c1@gutov.dev> X-Mailer: Apple Mail (2.3774.600.62) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289667 Archived-At: > On Aug 1, 2024, at 2:26=E2=80=AFPM, Dmitry Gutov = wrote: >=20 > Hi Yuan, >=20 > On 01/08/2024 10:36, Yuan Fu wrote: >> Actually, the original patch is perfectly good. The = =E2=80=9Csimplification=E2=80=9D I have in mind is more or less = unnecessary. >=20 > I think Damien is saying that patch#2 from his submission is not = necessary with your fix (commit 74bb1e5897f, IIUC). >=20 > So do you think it's a good idea to backport it to emacs-30? I=E2=80=99d rather apply Damien=E2=80=99s patch to emacs-30, that=E2=80=99= s a simple fix and doesn=E2=80=99t change the filling behavior. The = change I applied to master is more substantial, and apparently = introduced another regression that I now need to fix :-( Yuan=