From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#8856: 24.0.50; regression: special-display-frame is no longer dedicated Date: Sat, 25 Jun 2011 19:00:13 +0200 Message-ID: <4E06141D.80302@gmx.at> References: <853BDEF1AA9646ACB90724066E1A5951@us.oracle.com><4DF726A1.7020804@gmx.at><8E7452317D5B4FD183FD24E0FAA14F6F@us.oracle.com><4DFB6BBF.3080504@gmx.at><6FAF5DFD0E094823A512C3E0E87B6DF5@us.oracle.com><4DFE09A7.10500@gmx.at><0137606B527A48C69E3D6C704C5C6595@us.oracle.com><4DFF1709.3010409@gmx.at><309F7428711D4BEBB6063C60808D8069@us.oracle.com><4E00C54C.5080108@gmx.at><7AF0B637CAE14034973FBCC658AFEBD9@us.oracle.com><31769215C0FF4E1E89F9F641C5843E91@us.oracle.com><4E033CBA.1050700@gmx.at><4E037708.2000205@gmx.at><4E045081.3020009@gmx.at><90A40DD7F1B14BC1BE282ADB68D57511@us.oracle.com><4E05ED7B.2070 307@gmx.at> <4023AF2C90A24208ABCC1644CB15F776@us.oracle.com> <8A3D5626004B4945A624B69463A0B849@us.oracle.com> <4E06056! E.8030907@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1309021286 18716 80.91.229.12 (25 Jun 2011 17:01:26 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 25 Jun 2011 17:01:26 +0000 (UTC) Cc: 8856@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 25 19:01:22 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QaWES-0004KR-S1 for geb-bug-gnu-emacs@m.gmane.org; Sat, 25 Jun 2011 19:01:21 +0200 Original-Received: from localhost ([::1]:42413 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QaWES-0002YY-6Z for geb-bug-gnu-emacs@m.gmane.org; Sat, 25 Jun 2011 13:01:20 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:33244) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QaWEB-0002YH-IL for bug-gnu-emacs@gnu.org; Sat, 25 Jun 2011 13:01:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QaWEA-000236-BU for bug-gnu-emacs@gnu.org; Sat, 25 Jun 2011 13:01:03 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QaWEA-000232-68 for bug-gnu-emacs@gnu.org; Sat, 25 Jun 2011 13:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QaWE9-0001Uk-NU; Sat, 25 Jun 2011 13:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Jun 2011 17:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8856 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8856-submit@debbugs.gnu.org id=B8856.13090212243631 (code B ref 8856); Sat, 25 Jun 2011 17:01:01 +0000 Original-Received: (at 8856) by debbugs.gnu.org; 25 Jun 2011 17:00:24 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QaWDX-0000wU-DC for submit@debbugs.gnu.org; Sat, 25 Jun 2011 13:00:24 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.22]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1QaWDU-0000vz-BG for 8856@debbugs.gnu.org; Sat, 25 Jun 2011 13:00:21 -0400 Original-Received: (qmail invoked by alias); 25 Jun 2011 17:00:13 -0000 Original-Received: from 62-47-39-246.adsl.highway.telekom.at (EHLO [62.47.39.246]) [62.47.39.246] by mail.gmx.net (mp052) with SMTP; 25 Jun 2011 19:00:13 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18+NlNiYKw+mkrfvnnfuMvo1kfXYMmugxSDTdM2KQ CIp8NXDcfp9psm User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) In-Reply-To: X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 25 Jun 2011 13:01:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:47463 Archived-At: >> I downloaded your Icicles tarball and tried with throw-10. Everything >> seems to work as expected including focus redirection and resurrection >> of an iconified Completions frame. > > There should be no iconfied Completions frame in the test I gave you. When I type foo and eventually get the sole completion footnote-mode the Completions frame iconifies automatically. I didn't check why that happens, shouldn't it? When I then type M-x f TAB again it gets orderly resurrected. > The problem arises only when the Completions frame is newly _created_, as I > tried to explain. If you use `M-x f TAB o' (recipe) after the frame has already > been created then the input focus is not a problem. > > If you have the frame already, The Completions frame? It pops up automatically when I hit TAB and redirects focus to the Minibuffer frame. > then please delete it and try `M-x f TAB o' > again. > >> So if you don't use any additional strings the problem seems >> fixed. I can't tell why it doesn't work on your machine. > > As I said, it's possible that this is Windows-specific. Windows is I think > (thought) a bit peculiar when it comes to its auto-selecting a new frame - but > you said that most window mgrs do that now. I still wonder if this isn't > Windows-specific, since you cannot reproduce it and it is systematic for me when > I follow the same recipe. But I test this on Windows XP. >> Maybe some .el files have to be recompiled in order to work >> with my later fixes > > Do you mean my .el or .el from Emacs sources? In the files I provided for the > test, please use only .el, no .elc. From the Emacs sources. Maybe some completions-related stuff. >> so it's likely best to wait till Sean uploads the new binaries >> (IIRC this happens every Monday). As soon as you tried with >> the new binaries tell me what you get. > > I'll certainly do that. OK. > But what about that `display-buffer' call in > `icicle-display-candidates-in-Completions'? Can you suggest a change for it? > Does that code look like it _should_ work after your changes, or should it be > changed? It should work vacuously. But I'd like to know why you needed it earlier. Earlier Emacsen had `display-buffer' do ((let ((frames (or frame here frame is the value "0" you provide as argument (and (or use-pop-up-frames display-buffer-reuse-frames (not (last-nonminibuffer-frame))) 0) and the "0" you see in the previous line means exactly the same. Any visible or iconified frame provided you use either `pop-up-frames' or `display-buffer-reuse-frames'. And I suppose it doesn't make sense to use Icicles with these set to nil. Now if you insisted on searching only visible frames here I would see a problem ... (last-nonminibuffer-frame)))) (setq window-to-use (catch 'found ;; Search frames for a window displaying BUFFER. Return ;; the selected window only if we are allowed to do so. (dolist (window (get-buffer-window-list buffer 'nomini frames)) (when (or can-use-selected-window (not (eq (selected-window) window))) (throw 'found window)))))) ;; The buffer is already displayed in some window; use that. (window--display-buffer-1 window-to-use)) I can easily resurrect the old semantics of that argument for the few values t, 0, visible and a live frame but I would first like to see a real use case for it. > And you mentioned the `save-selected-window' around that `display-buffer' call. > Does that need to be changed somehow? I'm not quite sure what you expect it to do. IIUC you want the Completions window selected with focus redirected to the Minibuffer window. Now which window is the one whose selection you want to save here? Anyway, it shouldn't harm so leave it alone. martin