From: "Jan Djärv" <jan.h.d@swipnet.se>
To: Daiki Ueno <ueno@unixuser.org>
Cc: 8505-done@debbugs.gnu.org
Subject: bug#8505: 24.0.50; frame grows horizontally if scroll-bar-mode is non-nil
Date: Sun, 05 Jun 2011 21:08:29 +0200 [thread overview]
Message-ID: <4DEBD42D.3010607@swipnet.se> (raw)
In-Reply-To: <m3fwnrtftw.fsf-ueno@unixuser.org>
Hello.
I've checked in a fix. But it occured to me that the wrong thing will happen
if the theme is changed while Emacs runs, and the theme changed to has the
wider scroll bar. Can you change theme in Gnome 3?
Jan D.
Daiki Ueno skrev 2011-06-03 11.38:
> (Cc'ed Jan)
>
> Daiki Ueno<ueno@unixuser.org> writes:
>
>> If I build emacs with ./configure --with-x-toolkit=gtk3 and start it
>> with emacs -Q, the width of the Emacs window is growing with the lapse
>> of time.
>
> OK, I finally got it. This can be reproduced only with specific gtk-3.0
> themes (including GNOME3 default), where some widget properties have
> larger values than Emacs expects.
>
> Currently Emacs expects the scrollbar width at most 16 pixels.
>
> xfns.c:104442:
>
> void
> x_set_scroll_bar_default_width (struct frame *f)
> {
> int wid = FRAME_COLUMN_WIDTH (f);
>
> #ifdef USE_TOOLKIT_SCROLL_BARS
> /* A minimum width of 14 doesn't look good for toolkit scroll bars. */
> int width = 16 + 2 * VERTICAL_SCROLL_BAR_WIDTH_TRIM;
>
> However, gnome-themes-standard wants to render scrollbars in 22-pixel width.
>
> http://git.gnome.org/browse/gnome-themes-standard/tree/themes/Adwaita/gtk-3.0/gtk-widgets.css#n511
>
> .scrollbar {
> background-image: none;
> border-style: solid;
> -GtkRange-trough-border: 2;
> -GtkRange-arrow-scaling: 0.444;
> -GtkRange-slider-width: 18;
> -GtkRange-stepper-size: 18;
>
> 22 pixels = slider-width(18) + trough-border(2) * 2
>
> I confirmed that my problem is fixed if I increase the default width to
> 22.
>
> Since it happens with GNOME3 default theme, I would appreciate if it
> will be fixed before the pretest, though I don't know how easy to let
> Emacs to take account of GTK theme properties.
>
> Regards,
next prev parent reply other threads:[~2011-06-05 19:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 6:35 bug#8505: 24.0.50; frame grows horizontally if scroll-bar-mode is non-nil Daiki Ueno
2011-04-15 9:31 ` Daiki Ueno
2011-06-03 9:38 ` Daiki Ueno
2011-06-03 16:45 ` Jan Djärv
2011-06-05 19:08 ` Jan Djärv [this message]
2011-06-06 1:23 ` Daiki Ueno
2011-06-06 7:45 ` Jan Djärv
2011-06-14 21:13 ` Jan Djärv
2011-06-15 1:41 ` Daiki Ueno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DEBD42D.3010607@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=8505-done@debbugs.gnu.org \
--cc=ueno@unixuser.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.