From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Deniz Dogan Newsgroups: gmane.emacs.bugs Subject: bug#8799: 23.3; iswitchb Date: Sat, 04 Jun 2011 17:14:14 +0200 Message-ID: <4DEA4BC6.7020405@dogan.se> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1307200590 21053 80.91.229.12 (4 Jun 2011 15:16:30 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 4 Jun 2011 15:16:30 +0000 (UTC) Cc: 8799@debbugs.gnu.org To: Stephen Eglen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 04 17:16:26 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QSsaQ-0006zi-54 for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Jun 2011 17:16:26 +0200 Original-Received: from localhost ([::1]:41845 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QSsaP-0001jx-14 for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Jun 2011 11:16:25 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:46109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QSsa5-0001jY-BP for bug-gnu-emacs@gnu.org; Sat, 04 Jun 2011 11:16:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QSsa3-0002xa-OJ for bug-gnu-emacs@gnu.org; Sat, 04 Jun 2011 11:16:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49023) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QSsa3-0002xV-8N for bug-gnu-emacs@gnu.org; Sat, 04 Jun 2011 11:16:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QSsa2-0004HV-9n; Sat, 04 Jun 2011 11:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Deniz Dogan Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jun 2011 15:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8799-submit@debbugs.gnu.org id=B8799.130720051116398 (code B ref 8799); Sat, 04 Jun 2011 15:16:02 +0000 Original-Received: (at 8799) by debbugs.gnu.org; 4 Jun 2011 15:15:11 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QSsZC-0004GQ-Rj for submit@debbugs.gnu.org; Sat, 04 Jun 2011 11:15:11 -0400 Original-Received: from ch-smtp04.sth.basefarm.net ([80.76.153.5]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QSsZ9-0004Fy-GW for 8799@debbugs.gnu.org; Sat, 04 Jun 2011 11:15:08 -0400 Original-Received: from c80-216-105-155.bredband.comhem.se ([80.216.105.155]:56699 helo=[192.168.0.10]) by ch-smtp04.sth.basefarm.net with esmtp (Exim 4.76) (envelope-from ) id 1QSsYY-0001Tk-G4; Sat, 04 Jun 2011 17:14:32 +0200 User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10 In-Reply-To: X-Originating-IP: 80.216.105.155 X-Scan-Result: No virus found in message 1QSsYY-0001Tk-G4. X-Scan-Signature: ch-smtp04.sth.basefarm.net 1QSsYY-0001Tk-G4 cd8a1e03ee946431df299552864c1eb3 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 04 Jun 2011 11:16:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:46953 Archived-At: On 2011-06-04 11:42, Stephen Eglen wrote: > The following bug report was sent to me by Trevor Spiteri (thank you!). > > ---------------------------------------------------------------------- > The documentation for iswitchb-window-buffer-p states that it should > return nil if BUFFER is visible in the current frame. Sometimes this > does not happen. > > Suppose I am in a frame with two windows, one for buffer1 and the other > for buffer2, and I am currently in the window for buffer1. If I type: > C-x b b u f f e r 2 > this works correctly, iswitchb-window-buffer-p returns nil, and > consequently both windows will show buffer2. > > If instead of I use C-j, that is, I am in the window for > buffer1 and buffer2 is in the other window, and I type: > C-x b b u f f e r 2 C-j > iswitchb-window-buffer-p does not return nil, and consequently not both > windows will show buffer2, but the window for buffer2 becomes the > current window. > > To fix this, in the defun for iswitchb-window-buffer-p, the line > > (if (memq buffer blist) > > should be changed to: > > (if (member buffer blist) > > What I guess is happening is that using, buffer is a string > obtained from the list of buffers, so it is eq to the corresponding > element in blist. When C-j is used, buffer is taken from user input, and > is thus not eq to the corresponding element in blist. Although it is not > eq, it is still equal, so changing memq to member fixes the issue. > ---------------------------------------------------------------------- > > > I have pushed a fix for this to emacs-trunk, but I afterwards realized I should have pushed it to emacs-23. Could someone knowledgeable fix this for me? Thanks