Patch for iswitchb.el

Patch for iswitchb.el

[Stephen Eglen]

Please can someone apply this patch for iswitchb?  Thanks, Stephen

2011-06-04  Stephen Eglen  <stephen@gnu.org>

	* iswitchb.el (iswitchb-window-buffer-p): Use `member' rather 
	than `memq'.  Bug reported by Trevor Spiteri.

*** /Users/stephen/NOBACKUP/compiles/emacs-23.3/lisp/iswitchb.el~	2011-01-08 17:45:14.000000000 +0000
--- /Users/stephen/NOBACKUP/compiles/emacs-23.3/lisp/iswitchb.el	2011-06-04 07:28:22.000000000 +0100
***************
*** 1113,1119 ****
    (interactive)
    (let ((blist (iswitchb-get-buffers-in-frames 'current)))
      ;;If the buffer is visible in current frame, return nil
!     (if (memq buffer blist)
  	nil
        ;;  maybe in other frame or icon
        (get-buffer-window buffer 0) ; better than 'visible
--- 1113,1119 ----
    (interactive)
    (let ((blist (iswitchb-get-buffers-in-frames 'current)))
      ;;If the buffer is visible in current frame, return nil
!     (if (member buffer blist)
  	nil
        ;;  maybe in other frame or icon
        (get-buffer-window buffer 0) ; better than 'visible

Re: Patch for iswitchb.el

[Deniz Dogan]

On 2011-06-04 08:33, Stephen Eglen wrote:
> Please can someone apply this patch for iswitchb?  Thanks, Stephen
>
> 2011-06-04  Stephen Eglen<stephen@gnu.org>
>
> 	* iswitchb.el (iswitchb-window-buffer-p): Use `member' rather
> 	than `memq'.  Bug reported by Trevor Spiteri.
>
> *** /Users/stephen/NOBACKUP/compiles/emacs-23.3/lisp/iswitchb.el~	2011-01-08 17:45:14.000000000 +0000
> --- /Users/stephen/NOBACKUP/compiles/emacs-23.3/lisp/iswitchb.el	2011-06-04 07:28:22.000000000 +0100
> ***************
> *** 1113,1119 ****
>      (interactive)
>      (let ((blist (iswitchb-get-buffers-in-frames 'current)))
>        ;;If the buffer is visible in current frame, return nil
> !     (if (memq buffer blist)
>    	nil
>          ;;  maybe in other frame or icon
>          (get-buffer-window buffer 0) ; better than 'visible
> --- 1113,1119 ----
>      (interactive)
>      (let ((blist (iswitchb-get-buffers-in-frames 'current)))
>        ;;If the buffer is visible in current frame, return nil
> !     (if (member buffer blist)
>    	nil
>          ;;  maybe in other frame or icon
>          (get-buffer-window buffer 0) ; better than 'visible
>

Is the reported bug in the bug tracker?  If so, its ID should be in the 
ChangeLog.

/Deniz

Re: Patch for iswitchb.el

[Stephen Eglen]

2011-06-04  Stephen Eglen<stephen@gnu.org>
	* iswitchb.el (iswitchb-window-buffer-p): Use `member' rather
	than `memq'.  Bug#8799 reported by Trevor Spiteri.

> Is the reported bug in the bug tracker?  If so, its ID should be in
> the ChangeLog.

Thanks Deniz; it wasn't, but I just added it, and bug id now listed
above.  

Stephen

Re: Patch for iswitchb.el

[Deniz Dogan]

On 2011-06-04 11:52, Stephen Eglen wrote:
>
> 2011-06-04  Stephen Eglen<stephen@gnu.org>
> 	* iswitchb.el (iswitchb-window-buffer-p): Use `member' rather
> 	than `memq'.  Bug#8799 reported by Trevor Spiteri.
>
>> Is the reported bug in the bug tracker?  If so, its ID should be in
>> the ChangeLog.
>
> Thanks Deniz; it wasn't, but I just added it, and bug id now listed
> above.
>

I just pushed a fix for this.  Thanks.

Deniz

Re: Patch for iswitchb.el

[Deniz Dogan]

On 2011-06-04 13:04, Deniz Dogan wrote:
> On 2011-06-04 11:52, Stephen Eglen wrote:
>>
>> 2011-06-04 Stephen Eglen<stephen@gnu.org>
>> * iswitchb.el (iswitchb-window-buffer-p): Use `member' rather
>> than `memq'. Bug#8799 reported by Trevor Spiteri.
>>
>>> Is the reported bug in the bug tracker? If so, its ID should be in
>>> the ChangeLog.
>>
>> Thanks Deniz; it wasn't, but I just added it, and bug id now listed
>> above.
>>
>
> I just pushed a fix for this. Thanks.
>

Crap, I just realized I pushed this to emacs-trunk and not emacs-23. 
Could someone competent make sure it gets into emacs-23?

Thanks,
Deniz