all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org, jim@meyering.net, antoine.levitt@gmail.com
Subject: Re: md5 broken?
Date: Sat, 28 May 2011 12:12:19 -0700	[thread overview]
Message-ID: <4DE14913.9080507@cs.ucla.edu> (raw)
In-Reply-To: <83d3j2bw9g.fsf@gnu.org>

On 05/28/11 09:55, Eli Zaretskii wrote:
> "Builds" is not enough.  We also want to assure that every compiler
> that supports inline functions really sees the inline keyword there.

No, "#define inline /* empty */" is a perfectly adequate workaround.
This is the standard workaround on typical older hosts, and it
doesn't break anything, as the C Standard allows compilers to
ignore 'inline' entirely (on static functions, anyway, which is
what we're talking about here).

>> > so it does appear that it works with all supported builds.
> There's also the Windows build, which still supports non-GCC
> compilers.

Evidently it's not a significant problem with Windows, since it's been
in use for over a month without complaint.  If there turns
out to be a problem with some rarely-used ancient Windows compiler,
the Windows configuration file can just add a
"#define inline /* empty */" if that compiler is in use.



  reply	other threads:[~2011-05-28 19:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-28  9:32 md5 broken? Antoine Levitt
2011-05-28 12:23 ` Jim Meyering
2011-05-28 12:28   ` Antoine Levitt
2011-05-28 12:51   ` Eli Zaretskii
2011-05-28 13:32     ` Jim Meyering
2011-05-28 14:10       ` Eli Zaretskii
2011-05-28 16:09         ` Paul Eggert
2011-05-28 16:55           ` Eli Zaretskii
2011-05-28 19:12             ` Paul Eggert [this message]
2011-05-28 19:35               ` Eli Zaretskii
2011-05-28 22:47                 ` INLINE -> inline (was: md5 broken?) Paul Eggert
2011-05-29  4:51                   ` Eli Zaretskii
2011-05-29  8:05                   ` INLINE -> inline Jim Meyering
2011-05-30  2:47           ` md5 broken? Ken Raeburn
2011-05-30  5:31             ` Paul Eggert
2011-05-31  4:22               ` Ken Raeburn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DE14913.9080507@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=antoine.levitt@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jim@meyering.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.