From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#8675: error: token "@" is not valid in preprocessor expressions Date: Wed, 18 May 2011 15:59:14 -0700 Organization: UCLA Computer Science Department Message-ID: <4DD44F42.1050405__12810.1570917808$1305759618$gmane$org@cs.ucla.edu> References: <4DD0B118.1040205@cs.ucla.edu> <4DD321E5.2020202@cs.ucla.edu> <4DD32E3C.7080408@gmail.com> <4DD33392.7020907@cs.ucla.edu> <4DD42421.6090906@cs.ucla.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1305759618 7362 80.91.229.12 (18 May 2011 23:00:18 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 18 May 2011 23:00:18 +0000 (UTC) Cc: Christoph Scholtes , 8675@debbugs.gnu.org, Bug-gnulib To: Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 19 01:00:13 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QMpir-0006MA-FX for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 May 2011 01:00:09 +0200 Original-Received: from localhost ([::1]:35892 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMpir-0001U4-4U for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 May 2011 19:00:09 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:59639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMpio-0001SY-Ce for bug-gnu-emacs@gnu.org; Wed, 18 May 2011 19:00:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QMpin-0007cs-Ee for bug-gnu-emacs@gnu.org; Wed, 18 May 2011 19:00:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35614) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMpin-0007cY-AW for bug-gnu-emacs@gnu.org; Wed, 18 May 2011 19:00:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QMpim-0006dK-38; Wed, 18 May 2011 19:00:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 May 2011 23:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8675 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8675-submit@debbugs.gnu.org id=B8675.130575956225427 (code B ref 8675); Wed, 18 May 2011 23:00:03 +0000 Original-Received: (at 8675) by debbugs.gnu.org; 18 May 2011 22:59:22 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QMpi5-0006c4-RV for submit@debbugs.gnu.org; Wed, 18 May 2011 18:59:22 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QMpi4-0006bs-Ch for 8675@debbugs.gnu.org; Wed, 18 May 2011 18:59:21 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id E27D439E8116; Wed, 18 May 2011 15:59:14 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id blY6HqC4X-ol; Wed, 18 May 2011 15:59:14 -0700 (PDT) Original-Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 6ED0439E80F9; Wed, 18 May 2011 15:59:14 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Thunderbird/3.1.10 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 18 May 2011 19:00:04 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:46573 Archived-At: On 05/18/11 13:35, Andreas Schwab wrote: > Normally, if GNU make sees that a > makefile is remade it rereads it automatically. Ah, thanks, I didn't know that. So if we care only about GNU make, then all we need to do is to have unistd.h depend on Makefile. And, once unistd.h depends on Makefile then it need not depend on config.status (as Makefile already depends on config.status). Like this: --- a/modules/unistd +++ b/modules/unistd @@ -20,7 +20,7 @@ BUILT_SOURCES += unistd.h # We need the following in order to create an empty placeholder for # when the system doesn't have one. -unistd.h: unistd.in.h $(top_builddir)/config.status $(CXXDEFS_H) $(ARG_NONNULL_H) $(WARN_ON_USE_H) +unistd.h: unistd.in.h Makefile $(CXXDEFS_H) $(ARG_NONNULL_H) $(WARN_ON_USE_H) $(AM_V_GEN)rm -f $@-t $@ && \ { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \ sed -e 's|@''HAVE_UNISTD_H''@|$(HAVE_UNISTD_H)|g' \ Looking at the existing gnulib modules, I see that almost all of them have the .h file depend on config.status, but there's one exception: configmake.h depends on Makefile. Shouldn't they all depend on Makefile rather than on config.status? That should have helped to avoid this problem.