From: Christoph Scholtes <cschol2112@googlemail.com>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: 8454@debbugs.gnu.org, "Dirk-Jan C. Binnema" <djcb.bulk@gmail.com>
Subject: bug#8454: deftheme, :inherit & overriding existing values
Date: Mon, 09 May 2011 21:18:25 -0600 [thread overview]
Message-ID: <4DC8AE81.5070704@gmail.com> (raw)
In-Reply-To: <87mxix7xvm.fsf@stupidchicken.com>
On 5/8/2011 2:14 PM, Chong Yidong wrote:
> OK, I found a bug in the case where defface is called after loading a
> theme with settings for that face. The defface settings were not being
> applied; I've checked a fix into the trunk. However, I'm not sure this
> is the issue you are talking about, since this bug was not specific to
> the :inherit property. Could you check if your problem is fixed?
>
> One possible source of confusion, which may apply to Dirk-Jan's report,
> is that :inherit only tells Emacs to consult the parent face if a face
> attribute is unspecified. If the attribute is specified, it overrides
> the inheritance. So if your Custom theme want to "cancel out", say, any
> existing foreground attribute setting, you need something like
>
> '(froob ((t (:foreground unspecified :inherit parent-face))))
This did not fix it for me.
I think Dirk-Jan and I have the same issue, though, which is the
behavior of :inherit.
One example from my custom theme:
'(erc-default-face ((t (:inherit default))))
This is supposed to inherit from
'(default ((t (:background "#3f3f3f" :foreground "#dcdccc"))))
but it does not work.
This is probably related to what you describe above, but I don't really
understand it. foregound in erc-default-face is unspecified, right?
Should the inherit get the attributes from default or not?
I figured out a way to make my custom theme work, though. Loading it
through customize does not work, but if I open the theme file and eval
the buffer, it works and erc shows the my custom faces. Maybe this helps
to troubleshoot the problem?
Christoph
next prev parent reply other threads:[~2011-05-10 3:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-07 9:17 deftheme, :inherit & overriding existing values Dirk-Jan C. Binnema
2011-05-07 13:46 ` Christoph Scholtes
2011-05-08 19:19 ` bug#8454: " Chong Yidong
2011-05-08 20:14 ` Chong Yidong
2011-05-09 20:41 ` Dirk-Jan C. Binnema
2011-05-10 3:18 ` Christoph Scholtes [this message]
2011-05-13 4:50 ` Dirk-Jan C. Binnema
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC8AE81.5070704@gmail.com \
--to=cschol2112@googlemail.com \
--cc=8454@debbugs.gnu.org \
--cc=cyd@stupidchicken.com \
--cc=djcb.bulk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.