From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Deniz Dogan Newsgroups: gmane.emacs.devel Subject: Re: wdired autoload instructions Date: Sun, 08 May 2011 22:45:36 +0200 Message-ID: <4DC700F0.8090300@dogan.se> References: <4DC6F045.50908@dogan.se> <87aaex3p3y.fsf@ambire.localdomain> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1304887586 1158 80.91.229.12 (8 May 2011 20:46:26 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 8 May 2011 20:46:26 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 08 22:46:22 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QJArs-0004mM-NC for ged-emacs-devel@m.gmane.org; Sun, 08 May 2011 22:46:20 +0200 Original-Received: from localhost ([::1]:53119 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QJArs-00043z-AM for ged-emacs-devel@m.gmane.org; Sun, 08 May 2011 16:46:20 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:57777) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QJArp-00043p-IF for emacs-devel@gnu.org; Sun, 08 May 2011 16:46:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QJArm-0005Xt-PV for emacs-devel@gnu.org; Sun, 08 May 2011 16:46:17 -0400 Original-Received: from ch-smtp05.sth.basefarm.net ([80.76.153.6]:58369) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QJArm-0005XO-Dn for emacs-devel@gnu.org; Sun, 08 May 2011 16:46:14 -0400 Original-Received: from c80-216-105-155.bredband.comhem.se ([80.216.105.155]:60494 helo=[192.168.0.10]) by ch-smtp05.sth.basefarm.net with esmtp (Exim 4.73) (envelope-from ) id 1QJArE-0008GQ-Hp for emacs-devel@gnu.org; Sun, 08 May 2011 22:45:43 +0200 User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10 In-Reply-To: <87aaex3p3y.fsf@ambire.localdomain> X-Originating-IP: 80.216.105.155 X-Scan-Result: No virus found in message 1QJArE-0008GQ-Hp. X-Scan-Signature: ch-smtp05.sth.basefarm.net 1QJArE-0008GQ-Hp e35eb559ef6b805f19b9e1c0fcc55573 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.76.153.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:139230 Archived-At: On 2011-05-08 22:37, Thien-Thi Nguyen wrote: > () Deniz Dogan > () Sun, 08 May 2011 21:34:29 +0200 > > ;; (autoload 'wdired-change-to-wdired-mode "wdired") > ;; (eval-after-load "dired" > ;; '(lambda () > ;; (define-key dired-mode-map "r" 'wdired-change-to-wdired-mode) > ;; (define-key dired-mode-map > ;; [menu-bar immediate wdired-change-to-wdired-mode] > ;; '("Edit File Names" . wdired-change-to-wdired-mode)))) > > This is what I put in my init file: > > (autoload 'wdired-change-to-wdired-mode "wdired") > (eval-after-load "dired" > '(lambda () > (define-key dired-mode-map "r" 'wdired-change-to-wdired-mode))) > > Now when I start dired, "r" is still undefined and > `wdired-changeto-wdired-mode' is not recognized as a command (but is of course > a function). > > 1. Is this a documentation bug? > > Yes (in as much as the Commentary is a valid form of documentation). > To mark a function as a command to ‘autoload’, its INTERACTIVE arg must > be non-nil. > > 2. Is the quoting of `lambda' necessary? > > No, in two senses. First, because lambda forms are self-quoting. > Second, because ‘eval-after-load’ takes a form, not a thunk. > Evaluating a self-quoting lambda form only yields an anonymous > function, which is not what is desired in this case. Unless the > form is to be computed, normally it should be quoted, so quoting > is indeed necessary (just not of a lambda form). > > In sum, a better blurb would be: > > (autoload 'wdired-change-to-wdired-mode "wdired" > "Switch to Wdired mode." t) > (eval-after-load "dired" > '(progn > (define-key dired-mode-map "r" 'wdired-change-to-wdired-mode) > (define-key dired-mode-map > [menu-bar immediate wdired-change-to-wdired-mode] > '("Edit File Names" . wdired-change-to-wdired-mode)))) > Would anyone, for any reason, mind if we change the comment to recommend this instead? > Anyway, it seems that in in Dired mode, ‘C-x C-q’ runs a command > that calls ‘wdired-change-to-wdired-mode’ so perhaps you can simplify > your customizations to use that command directly. > Thanks, I did not know that.