From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.comp.lib.gnulib.bugs,gmane.emacs.devel Subject: Putting .h files into lib_SOURCES? (was: Changes in lib/) Date: Sat, 07 May 2011 14:33:50 -0700 Organization: UCLA Computer Science Department Message-ID: <4DC5BABE.3070304@cs.ucla.edu> References: <831v0aluo9.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1304804063 29357 80.91.229.12 (7 May 2011 21:34:23 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 7 May 2011 21:34:23 +0000 (UTC) Cc: bug-gnulib , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Sat May 07 23:34:19 2011 Return-path: Envelope-to: gnu-bug-gnulib@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QIp8k-0007iE-LA for gnu-bug-gnulib@m.gmane.org; Sat, 07 May 2011 23:34:18 +0200 Original-Received: from localhost ([::1]:46125 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QIp8j-0005kA-RV for gnu-bug-gnulib@m.gmane.org; Sat, 07 May 2011 17:34:17 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:33482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QIp8a-0005Zy-5V for bug-gnulib@gnu.org; Sat, 07 May 2011 17:34:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QIp8Y-00058Z-Kv for bug-gnulib@gnu.org; Sat, 07 May 2011 17:34:08 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:54046) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QIp8Y-00057i-Bp; Sat, 07 May 2011 17:34:06 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 7D8AF39E80FA; Sat, 7 May 2011 14:33:57 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id elmNwMVZ++Qa; Sat, 7 May 2011 14:33:55 -0700 (PDT) Original-Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id BD17739E8113; Sat, 7 May 2011 14:33:55 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17) Gecko/20110424 Thunderbird/3.1.10 In-Reply-To: <831v0aluo9.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 131.179.128.62 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Original-Sender: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Xref: news.gmane.org gmane.comp.lib.gnulib.bugs:26522 gmane.emacs.devel:139210 Archived-At: On 05/07/11 02:35, Eli Zaretskii wrote: > As result of recent changes in the lib/ subdirectory, > autogen/Makefile.in (which reflects changes in lib/Makefile.in at > least on some Posix platform) acquired the following strange change: > > +am__libgnu_a_SOURCES_DIST = allocator.c careadlinkat.c dtoastr.c \ > + gettext.h ignore-value.h verify.h > +am__objects_1 = > am_libgnu_a_OBJECTS = allocator.$(OBJEXT) careadlinkat.$(OBJEXT) \ > - dtoastr.$(OBJEXT) > + dtoastr.$(OBJEXT) $(am__objects_1) $(am__objects_1) > > Why is $(am__objects_1) mentioned twice in the last line? That's > harmless as long as the value is empty, but what if it becomes > non-empty? I installed the following patch into gnulib to fix this glitch, and this should be propagated into Emacs the next time someone (probably me :-) does a "make sync-from-gnulib". I'll CC: this to bug-gnulib, as it raises the more-general issue of why we ever put gnulib's .h files into lib_SOURCES. >From e7e83b6713e646fce656245afaaa8985b6cfb634 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 7 May 2011 14:29:30 -0700 Subject: [PATCH] ignore-value, verify: Omit include files from lib_SOURCES. * modules/ignore-value, modules/verify (Makefile.am): Don't put ignore-value.h, or verify.h, into lib_SOURCES, as that leads Automake to duplicate use of am__objects_... variables in Makefile.in. See . --- ChangeLog | 9 +++++++++ modules/ignore-value | 1 - modules/verify | 1 - 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index c84262b..67e7993 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,12 @@ +2011-05-07 Paul Eggert + + ignore-value, verify: Omit include files from lib_SOURCES. + * modules/ignore-value, modules/verify (Makefile.am): + Don't put ignore-value.h, or verify.h, into lib_SOURCES, as + that leads Automake to duplicate use of am__objects_... variables + in Makefile.in. See + . + 2011-05-07 Bruno Haible fclose: Simplify autoconf macro. diff --git a/modules/ignore-value b/modules/ignore-value index 8d48863..9d00c1f 100644 --- a/modules/ignore-value +++ b/modules/ignore-value @@ -10,7 +10,6 @@ configure.ac: AC_REQUIRE([AC_C_INLINE]) Makefile.am: -lib_SOURCES += ignore-value.h Include: "ignore-value.h" diff --git a/modules/verify b/modules/verify index eebb1cd..5216ce8 100644 --- a/modules/verify +++ b/modules/verify @@ -9,7 +9,6 @@ Depends-on: configure.ac: Makefile.am: -lib_SOURCES += verify.h Include: "verify.h" -- 1.7.4.4