From: Robert Goldman <rpgoldman@sift.info>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: Carsten Dominik <cdominik@newartisans.com>, emacs-orgmode@gnu.org
Subject: Re: [Accepted] Make the latex export preprocessor rewrite #+INDEX to \index.
Date: Wed, 04 May 2011 17:46:12 -0500 [thread overview]
Message-ID: <4DC1D734.1080102@sift.info> (raw)
In-Reply-To: <11C6FAAE-B0EA-4A93-A85D-6B629BF64000@gmail.com>
On 5/4/11 May 4 -5:36 PM, Carsten Dominik wrote:
>
> On 4.5.2011, at 17:08, Robert Goldman wrote:
>
>> On 5/4/11 May 4 -2:59 AM, Carsten Dominik wrote:
>>> Patch 767 (http://patchwork.newartisans.com/patch/767/) is now "Accepted".
>>>
>>> Maintainer comment: Pushed with modifications. Some optimization, and the original patch would have stopped at the first #+index line that was missing the entry... Please verify that it still works
>>>
>>> This relates to the following submission:
>>>
>>> http://mid.gmane.org/%3C1303991243-30731-2-git-send-email-rpgoldman%40sift.info%3E
>>
>> I think there's a minor problem with the patch. AFAICT, it binds the
>> local variable 'entry' but does not read it (instead it uses the match
>> text directly).
>
> That is right, that is unnecessary. I removed that, thanks.
>
>> As an aside, it might be desirable to handle the empty index case that
>> you identified. E.g.,
>>
>> (if (> (match-end 1) (match-beginning 1))
>> ...rewrite the index entry...
>> ;; else
>> emit a warning
>> rewrite the index entry as the empty string
>> )
>
> You mean, instead of ignoring it, there should be an error message
> or warning?
>
> - Carsten
I was suggesting a warning. I don't /believe/ (I'm not in a position to
check right now) that the previous code ignored it --- I think it was
going to write an empty index --- \index{} --- and I'm not sure whether
that would be happy with Latex, or would generate a hard-to-debug error
downstream after processing the generated latex.
I also don't know if it's easy to report the particular line in the org
file that's bad. I suspect not, because of the preprocessing, but I
could be wrong.
best,
R
prev parent reply other threads:[~2011-05-04 22:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 11:47 Translate #+INDEX to Latex \index{} on export rpgoldman
2011-04-28 11:47 ` [PATCH] Make the latex export preprocessor rewrite #+INDEX to \index rpgoldman
2011-04-28 12:33 ` Nick Dokos
2011-04-28 15:23 ` Robert Goldman
2011-04-28 15:29 ` Robert Goldman
2011-04-28 15:38 ` Patch --- adding an easy template for #+index rpgoldman
2011-04-28 19:11 ` Bernt Hansen
2011-04-28 19:59 ` Robert Goldman
2011-04-28 21:31 ` Bernt Hansen
2011-04-28 15:38 ` [PATCH] Add an easy template for index (i), and move include file to I from i rpgoldman
2011-05-04 7:49 ` [Accepted] " Carsten Dominik
2011-04-29 21:45 ` Bug Re: [PATCH] Make the latex export preprocessor rewrite #+INDEX to \index Robert Goldman
2011-05-04 7:59 ` [Accepted] " Carsten Dominik
2011-05-04 15:08 ` Robert Goldman
2011-05-04 22:36 ` Carsten Dominik
2011-05-04 22:46 ` Robert Goldman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC1D734.1080102@sift.info \
--to=rpgoldman@sift.info \
--cc=carsten.dominik@gmail.com \
--cc=cdominik@newartisans.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.