From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#8512: possibly uninitialized variable in x_produce_glyphs Date: Sat, 16 Apr 2011 12:40:36 -0700 Organization: UCLA Computer Science Department Message-ID: <4DA9F0B4.1090204@cs.ucla.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1302984463 3528 80.91.229.12 (16 Apr 2011 20:07:43 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 16 Apr 2011 20:07:43 +0000 (UTC) To: 8512@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 16 22:07:39 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QBBmM-0003Nj-UE for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Apr 2011 22:07:39 +0200 Original-Received: from localhost ([::1]:59002 helo=lists2.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QBBmM-0007NQ-36 for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Apr 2011 16:07:38 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:51241) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QBBmI-0007NA-Ez for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2011 16:07:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QBBmH-0002d7-KI for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2011 16:07:34 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55556) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QBBmH-0002d3-Ha for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2011 16:07:33 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QBBNa-0007Yl-HN; Sat, 16 Apr 2011 15:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Apr 2011 19:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 8512 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.130298286328992 (code B ref -1); Sat, 16 Apr 2011 19:42:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 16 Apr 2011 19:41:03 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QBBMd-0007XZ-Ej for submit@debbugs.gnu.org; Sat, 16 Apr 2011 15:41:03 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QBBMa-0007X2-Sy for submit@debbugs.gnu.org; Sat, 16 Apr 2011 15:41:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QBBMV-0007Hq-1i for submit@debbugs.gnu.org; Sat, 16 Apr 2011 15:40:55 -0400 Original-Received: from lists.gnu.org ([140.186.70.17]:45941) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QBBMV-0007Hl-08 for submit@debbugs.gnu.org; Sat, 16 Apr 2011 15:40:55 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:39019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QBBMU-0003Ug-3n for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2011 15:40:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QBBMT-0007HQ-Ee for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2011 15:40:54 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:49540) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QBBMT-0007Fu-9V for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2011 15:40:53 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id D352D39E80F7 for ; Sat, 16 Apr 2011 12:40:43 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NGm1Resx1Ebr for ; Sat, 16 Apr 2011 12:40:43 -0700 (PDT) Original-Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 5FEBB39E80DB for ; Sat, 16 Apr 2011 12:40:43 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.14) Gecko/20110223 Thunderbird/3.1.8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 16 Apr 2011 15:42:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:45841 Archived-At: In the Emacs trunk, GCC 3.4.3 on Solaris 10 warns about a possibly uninitialized variable in x_produce_glyphs, and it's not clear to me that this diagnostic is wrong. The function assumes that cmp->glyph_len > 0, but a quick look through the rest of Emacs suggests that it's possible that it's zero. To play it safe until someone with more expertise about glyphs can look at the problem, I plan to install this patch: --- src/xdisp.c 2011-04-16 01:54:37 +0000 +++ src/xdisp.c 2011-04-16 19:24:11 +0000 @@ -22712,7 +22712,7 @@ x_produce_glyphs (struct it *it) int lbearing, rbearing; int i, width, ascent, descent; int left_padded = 0, right_padded = 0; - int c; + int c = 0; /* FIXME: Is 0 right here, when cmp->glyph_len == 0? */ XChar2b char2b; struct font_metrics *pcm; int font_not_found_p;