From: Paul Eggert <eggert@cs.ucla.edu>
To: Emacs-Devel devel <emacs-devel@gnu.org>
Subject: checking static vs extern symbols
Date: Thu, 14 Apr 2011 16:52:41 -0700 [thread overview]
Message-ID: <4DA788C9.7010102@cs.ucla.edu> (raw)
In-Reply-To: <4DA3AC70.6070609@cs.ucla.edu>
No further comment, and it appears that there wasn't consensus
to mark DEFUNs as to whether they were static, so I removed that
part of the change. Also, I removed the INFUN macro too, as
Dan Nicolaescu suggested. What's was left, was changing several
C functions and variables to be 'static', plus removing some
code that was thereby exposed as being unused. I merged this
to the trunk as bzr 103913.
I have an approximately 100-line shell script that reports
C variables and functions that are exported but shouldn't be.
It finds every extern symbol that is not used by any
other module, and isn't one of the exceptional cases (the
biggest exception being DEFUNs). I plan to make this shell
script run as part of a new 'make maintainer-check' action.
I could call this shell script 'src/extern-check', or could
give it other names (in other directories) if people would prefer,
but the basic idea is that "make maintainer-check" is intended
to be used by maintainers who are running on platforms
that have the proper tools available, and that "make maintainer-check"
reports glitches such as unwanted exports. (I have some
other maintainer checks in mind, but one step at a time.)
next prev parent reply other threads:[~2011-04-14 23:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 5:47 DEFU* macro name for a extern DEFUN: DEFUE? DEFUNEX? Paul Eggert
2011-04-11 6:27 ` Dan Nicolaescu
2011-04-11 6:37 ` Paul Eggert
2011-04-11 10:39 ` Juanma Barranquero
2011-04-11 16:49 ` Paul Eggert
2011-04-11 14:34 ` Jason Rumney
2011-04-11 22:37 ` Chong Yidong
2011-04-12 1:35 ` Paul Eggert
2011-04-14 23:52 ` Paul Eggert [this message]
2011-04-15 8:23 ` checking static vs extern symbols Eli Zaretskii
2011-04-15 1:15 ` DEFU* macro name for a extern DEFUN: DEFUE? DEFUNEX? Stefan Monnier
2011-04-12 3:34 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA788C9.7010102@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.